From: Ben Greear <greearb@candelatech.com>
To: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Michal Kazior <michal.kazior@tieto.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Fix getting stats from firmware.
Date: Fri, 21 Mar 2014 10:29:52 -0700 [thread overview]
Message-ID: <532C7710.1050102@candelatech.com> (raw)
In-Reply-To: <CAEFj985WKAOp9vewgZW8LYB9KdUxh2GJG5uhAjRdCSiAd-y1sQ@mail.gmail.com>
On 03/21/2014 09:42 AM, Yeoh Chun-Yeow wrote:
> Hi, Ben
>
> I did a quick check again on STA mode. With or without your patch, the
> printed peer stats are both identical but both wrong. See below:
Ok, it's unlikely my patch would have changed it one way or another.
I'll leave my patch mostly as it was (ie, no special handling for
older v/s newer firmware).
I am just starting to look at stats, and since 10.x was completely
broken and has been for some time, probably no one else has paid
much attention to it yet either.
Thanks for testing.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-03-21 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 0:05 [PATCH] ath10k: Fix getting stats from firmware greearb
2014-03-21 6:33 ` Michal Kazior
2014-03-21 6:41 ` Yeoh Chun-Yeow
2014-03-21 16:03 ` Ben Greear
2014-03-21 16:12 ` Kalle Valo
2014-03-21 16:42 ` Yeoh Chun-Yeow
2014-03-21 16:48 ` Yeoh Chun-Yeow
2014-03-21 18:51 ` Ben Greear
2014-03-21 17:29 ` Ben Greear [this message]
2014-03-21 15:56 ` Ben Greear
2014-03-21 16:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C7710.1050102@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).