From: Arend van Spriel <arend@broadcom.com>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH] mac80211: add vif to flush call
Date: Thu, 27 Mar 2014 19:15:23 +0100 [thread overview]
Message-ID: <53346ABB.1060907@broadcom.com> (raw)
In-Reply-To: <1395912629-1458-1-git-send-email-egrumbach@gmail.com>
On 03/27/14 10:30, Emmanuel Grumbach wrote:
> From: Emmanuel Grumbach<emmanuel.grumbach@intel.com>
>
> This will allow the low level driver to make decision based
> on the vif such as queues etc...
> Since the vif might be NULL, we can't add it to the tracing
> functions.
Although this argument sound fair my rule about interfaces is that a
change should be needed, ie. a low-level driver that needs the info,
instead of hypothetical use. You have one up your sleeve ? ;-)
Regards,
Arend
> Signed-off-by: Emmanuel Grumbach<emmanuel.grumbach@intel.com>
> ---
> drivers/net/wireless/ath/ar5523/ar5523.c | 3 ++-
> drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
> drivers/net/wireless/ath/ath9k/main.c | 3 ++-
> drivers/net/wireless/ath/carl9170/main.c | 4 +++-
> drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 3 ++-
> drivers/net/wireless/cw1200/sta.c | 3 ++-
> drivers/net/wireless/cw1200/sta.h | 3 ++-
> drivers/net/wireless/iwlegacy/common.c | 3 ++-
> drivers/net/wireless/iwlegacy/common.h | 3 ++-
> drivers/net/wireless/iwlwifi/dvm/mac80211.c | 3 ++-
> drivers/net/wireless/mac80211_hwsim.c | 4 +++-
> drivers/net/wireless/p54/main.c | 3 ++-
> drivers/net/wireless/rt2x00/rt2x00.h | 3 ++-
> drivers/net/wireless/rt2x00/rt2x00mac.c | 3 ++-
> drivers/net/wireless/rtlwifi/core.c | 3 ++-
> drivers/net/wireless/ti/wlcore/main.c | 3 ++-
> include/net/mac80211.h | 4 +++-
> net/mac80211/driver-ops.h | 8 +++++++-
> net/mac80211/util.c | 2 +-
> 19 files changed, 45 insertions(+), 19 deletions(-)
next prev parent reply other threads:[~2014-03-27 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 9:30 [PATCH] mac80211: add vif to flush call Emmanuel Grumbach
2014-03-27 18:15 ` Arend van Spriel [this message]
2014-03-27 18:22 ` Johannes Berg
2014-03-27 18:50 ` [PATCH] iwlwifi: mvm: implement mac80211's flush callback Emmanuel Grumbach
2014-03-28 8:28 ` [PATCH] mac80211: add vif to flush call Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53346ABB.1060907@broadcom.com \
--to=arend@broadcom.com \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).