From: Antonio Quartulli <antonio@meshcoding.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: stefan.pietsch@lsexperts.de, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 2/2] cfg80211: ignore invalid BSSIDs when looking for BSSes
Date: Thu, 10 Apr 2014 09:00:32 +0200 [thread overview]
Message-ID: <53464190.1030202@meshcoding.com> (raw)
In-Reply-To: <1397075965-2684-2-git-send-email-johannes@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On 09/04/14 22:39, Johannes Berg wrote:
> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index 7d09a712cb1f..746c56ebd66c 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -540,6 +540,8 @@ struct cfg80211_bss *cfg80211_get_bss(struct wiphy *wiphy,
> continue;
> if (channel && bss->pub.channel != channel)
> continue;
> + if (!is_valid_ether_addr(bss->pub.bssid))
> + continue;
Wouldn't it be better to prevent such entry to end up in the bss list at
all? (i.e. filtering during the scan?)
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-04-10 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 20:39 [PATCH 1/2] cfg80211: reject invalid IBSS BSSIDs in wext compat code Johannes Berg
2014-04-09 20:39 ` [PATCH 2/2] cfg80211: ignore invalid BSSIDs when looking for BSSes Johannes Berg
2014-04-10 7:00 ` Antonio Quartulli [this message]
2014-04-10 7:59 ` Johannes Berg
2014-04-10 8:25 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53464190.1030202@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=stefan.pietsch@lsexperts.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).