From: Larry Finger <Larry.Finger@lwfinger.net>
To: Colin King <colin.king@canonical.com>,
Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon
Date: Mon, 21 Apr 2014 12:15:44 -0500 [thread overview]
Message-ID: <53555240.70806@lwfinger.net> (raw)
In-Reply-To: <1398098324-5193-1-git-send-email-colin.king@canonical.com>
On 04/21/2014 11:38 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> static code analysis from cppcheck reports:
>
> [drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
> (error) Uninitialized variable: packet_beacon
>
> packet_beacon is not initialized and hence packet_beacon
> contains garbage from the stack, so set it to false.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This change should have a "Cc: Stable <stable@vger.kernel.org> [3.10+] notation.
Other than that, Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
John: Is it possible for you to add stable, or do you want Colin to resubmit.
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> index 06ef47c..5b4c225 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> @@ -293,7 +293,7 @@ static void _rtl88ee_translate_rx_signal_stuff(struct ieee80211_hw *hw,
> u8 *psaddr;
> __le16 fc;
> u16 type, ufc;
> - bool match_bssid, packet_toself, packet_beacon, addr;
> + bool match_bssid, packet_toself, packet_beacon = false, addr;
>
> tmp_buf = skb->data + pstatus->rx_drvinfo_size + pstatus->rx_bufshift;
>
>
next prev parent reply other threads:[~2014-04-21 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 16:38 [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon Colin King
2014-04-21 17:15 ` Larry Finger [this message]
2014-04-22 17:59 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53555240.70806@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).