* [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon
@ 2014-04-21 16:38 Colin King
2014-04-21 17:15 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2014-04-21 16:38 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, John W. Linville, linux-wireless,
netdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
static code analysis from cppcheck reports:
[drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
(error) Uninitialized variable: packet_beacon
packet_beacon is not initialized and hence packet_beacon
contains garbage from the stack, so set it to false.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
index 06ef47c..5b4c225 100644
--- a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
@@ -293,7 +293,7 @@ static void _rtl88ee_translate_rx_signal_stuff(struct ieee80211_hw *hw,
u8 *psaddr;
__le16 fc;
u16 type, ufc;
- bool match_bssid, packet_toself, packet_beacon, addr;
+ bool match_bssid, packet_toself, packet_beacon = false, addr;
tmp_buf = skb->data + pstatus->rx_drvinfo_size + pstatus->rx_bufshift;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon
2014-04-21 16:38 [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon Colin King
@ 2014-04-21 17:15 ` Larry Finger
2014-04-22 17:59 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2014-04-21 17:15 UTC (permalink / raw)
To: Colin King, Chaoming Li, John W. Linville, linux-wireless, netdev
Cc: linux-kernel
On 04/21/2014 11:38 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> static code analysis from cppcheck reports:
>
> [drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
> (error) Uninitialized variable: packet_beacon
>
> packet_beacon is not initialized and hence packet_beacon
> contains garbage from the stack, so set it to false.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This change should have a "Cc: Stable <stable@vger.kernel.org> [3.10+] notation.
Other than that, Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
John: Is it possible for you to add stable, or do you want Colin to resubmit.
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> index 06ef47c..5b4c225 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> @@ -293,7 +293,7 @@ static void _rtl88ee_translate_rx_signal_stuff(struct ieee80211_hw *hw,
> u8 *psaddr;
> __le16 fc;
> u16 type, ufc;
> - bool match_bssid, packet_toself, packet_beacon, addr;
> + bool match_bssid, packet_toself, packet_beacon = false, addr;
>
> tmp_buf = skb->data + pstatus->rx_drvinfo_size + pstatus->rx_bufshift;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon
2014-04-21 17:15 ` Larry Finger
@ 2014-04-22 17:59 ` John W. Linville
0 siblings, 0 replies; 3+ messages in thread
From: John W. Linville @ 2014-04-22 17:59 UTC (permalink / raw)
To: Larry Finger
Cc: Colin King, Chaoming Li, linux-wireless, netdev, linux-kernel
On Mon, Apr 21, 2014 at 12:15:44PM -0500, Larry Finger wrote:
> On 04/21/2014 11:38 AM, Colin King wrote:
> >From: Colin Ian King <colin.king@canonical.com>
> >
> >static code analysis from cppcheck reports:
> >
> >[drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
> > (error) Uninitialized variable: packet_beacon
> >
> >packet_beacon is not initialized and hence packet_beacon
> >contains garbage from the stack, so set it to false.
> >
> >Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >---
> > drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This change should have a "Cc: Stable <stable@vger.kernel.org> [3.10+] notation.
>
> Other than that, Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> John: Is it possible for you to add stable, or do you want Colin to resubmit.
Got it, thanks...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-22 18:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-21 16:38 [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon Colin King
2014-04-21 17:15 ` Larry Finger
2014-04-22 17:59 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).