From: Felix Fietkau <nbd@openwrt.org>
To: Tim Harvey <tharvey@gateworks.com>, linux-wireless@vger.kernel.org
Cc: John Linville <linville@tuxdriver.com>,
ath9k-devel@lists.ath9k.org, Ben Greear <greearb@candelatech.com>
Subject: Re: [PATCH 2/2] ath9k: add a recv budget
Date: Tue, 29 Apr 2014 14:25:12 +0200 [thread overview]
Message-ID: <535F9A28.9070809@openwrt.org> (raw)
In-Reply-To: <CAJ+vNU1mdgtZuT8NeQmZDJ25cufohqZyvcG4y2EM8tjpfntG7w@mail.gmail.com>
On 2014-04-29 14:04, Tim Harvey wrote:
> On Tue, Apr 22, 2014 at 2:09 AM, Felix Fietkau <nbd@openwrt.org> wrote:
>> On 2014-04-22 01:14, Tim Harvey wrote:
>>> Implement a recv budget so that in cases of high traffic we still allow other
>>> taskets to get processed.
>>>
>>> Without this, we can encounter a host of issues during high wireless traffic
>>> reception depending on system load including rcu stall's detected (ARM),
>>> soft lockups, failure to service critical tasks such as watchdog resets,
>>> and triggering of the tx stuck tasklet.
>>>
>>> The same thing was proposed previously by Ben:
>>> http://www.spinics.net/lists/linux-wireless/msg112891.html
>>>
>>> The only difference here is that I make sure only processed packets are counted
>>> in the budget by checking at the end of the rx loop.
>>>
>>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>> For both patches:
>> Acked-by: Felix Fietkau <nbd@openwrt.org>
>>
>
> +cc ath9k-devel@lists.ath9k.org
> +cc Ben Greear
>
> Any other ack's or comments on these? These address some fairly
> long-standing bugs.
No need for further ack's or comments, since the change has been picked
up by John already.
- Felix
next prev parent reply other threads:[~2014-04-29 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 23:14 [PATCH 1/2] ath9k: fix possible hang on flush Tim Harvey
2014-04-21 23:14 ` [PATCH 2/2] ath9k: add a recv budget Tim Harvey
2014-04-22 9:09 ` Felix Fietkau
2014-04-29 12:04 ` Tim Harvey
2014-04-29 12:25 ` Felix Fietkau [this message]
2014-04-29 19:23 ` Adrian Chadd
2014-04-29 12:02 ` [PATCH 1/2] ath9k: fix possible hang on flush Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535F9A28.9070809@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).