linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Sven Eckelmann <sven@narfation.org>
Cc: Tim Gardner <rtg.canonical@gmail.com>,
	Nicolas Vaquero <nicovaq92@hotmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Kernel source
Date: Wed, 30 Apr 2014 09:39:17 -0500	[thread overview]
Message-ID: <53610B15.4000607@lwfinger.net> (raw)
In-Reply-To: <3262959.TlL8alHHte@bentobox>

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Sven and Tim,

Attached is a one-line fix for the problem that shows up between 3.8.0-36 and 
3.8.0-37. It is just a bare patch file, but feel free to add any explanatory 
text to make it a proper commit.

I have no real understanding as to why this line of code does not cause any 
problems with later kernel versions, but it does here. In addition, I have not 
had any reports of problems with other users. That makes me suspect some kind of 
bad interaction with the user-space network control components in 12.04.

Would it be helpful for Nicolas to prepare a bug report at Ubuntu?

Larry



[-- Attachment #2: fix_ubuntu_crash --]
[-- Type: text/plain, Size: 479 bytes --]

Index: linux-3.8.37/drivers/net/wireless/rtlwifi/core.c
===================================================================
--- linux-3.8.37.orig/drivers/net/wireless/rtlwifi/core.c
+++ linux-3.8.37/drivers/net/wireless/rtlwifi/core.c
@@ -187,7 +187,6 @@ static int rtl_op_add_interface(struct i
 					rtlpriv->cfg->maps
 					[RTL_IBSS_INT_MASKS]);
 		}
-		mac->link_state = MAC80211_LINKED;
 		break;
 	case NL80211_IFTYPE_ADHOC:
 		RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,


  parent reply	other threads:[~2014-04-30 14:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 15:44 Kernel source Larry Finger
2014-04-29  7:42 ` Sven Eckelmann
2014-04-29 15:43   ` Larry Finger
2014-04-30 13:37     ` Tim Gardner
2014-04-30 14:39   ` Larry Finger [this message]
2014-04-30 17:50     ` Nicolas Vaquero
2014-05-01 12:31       ` Seth Forshee
2014-05-01 13:08       ` Tim Gardner
2014-05-01 15:01         ` Larry Finger
2014-05-01 15:12           ` Tim Gardner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53610B15.4000607@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nicovaq92@hotmail.com \
    --cc=rtg.canonical@gmail.com \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).