From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, gregory.greenman@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 10/19] wifi: iwlwifi: limit EHT capabilities based on PCIe link speed
Date: Wed, 21 Jun 2023 13:57:53 +0200 [thread overview]
Message-ID: <53612acba151d031f636626db20c1c60db09fdd0.camel@sipsolutions.net> (raw)
In-Reply-To: <d220c5b6-7c8f-19cd-12d0-ceb484e29e48@candelatech.com>
On Tue, 2023-06-20 at 06:19 -0700, Ben Greear wrote:
> On 6/20/23 3:03 AM, gregory.greenman@intel.com wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > If a discrete NIC is connected to a PCIe link hat isn't at least
> > Gen3 (8.0 GT/s), then we cannot sustain 320 MHz traffic, so remove
> > that from EHT capabilities in that case.
> >
> > While at it, also move setting 320 MHz beamformee to the right
> > place in the code so it's not set while not supporting 320 MHz.
>
> Is there not an advantage to allowing 320Mhz for longer distance connections
> where signal is relatively weak, so over-all tput would easily fit in lesser
> pcie bus? Especially on 6E band where the US regdom allows more over-all power
> when using wider bandwidths?
>
I actually don't know. This surely isn't ideal, but it's the only way to
really force the AP to not send too much than the NIC can pass out, and
it gets unhappy if it can't.
johannes
next prev parent reply other threads:[~2023-06-21 11:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 10:03 [PATCH 00/19] wifi: iwlwifi: updates intended for v6.5 2023-06-20 gregory.greenman
2023-06-20 10:03 ` [PATCH 01/19] wifi: iwlwifi: pcie: refactor RB status size calculation gregory.greenman
2023-06-20 10:03 ` [PATCH 02/19] wifi: iwlwifi: pcie: add size assertions gregory.greenman
2023-06-20 10:03 ` [PATCH 03/19] wifi: iwlwifi: mvm: check the right csa_active gregory.greenman
2023-06-20 10:03 ` [PATCH 04/19] wifi: iwlwifi: fw: send marker cmd before suspend cmd gregory.greenman
2023-06-20 10:03 ` [PATCH 05/19] wifi: iwlwifi: mvm: make iwl_mvm_set_fw_mu_edca_params mld aware gregory.greenman
2023-06-20 10:03 ` [PATCH 06/19] wifi: iwlwifi: nvm: handle EHT/320 MHz regulatory flag gregory.greenman
2023-06-20 10:03 ` [PATCH 07/19] wifi: iwlwifi: mvm: use EHT maximum MPDU length on 2.4 GHz gregory.greenman
2023-06-20 10:03 ` [PATCH 08/19] wifi: iwlwifi: mvm: use min_t() for agg_size gregory.greenman
2023-06-20 10:03 ` [PATCH 09/19] wifi: iwlwifi: mvm: add EHT A-MPDU size exponent support gregory.greenman
2023-06-20 10:03 ` [PATCH 10/19] wifi: iwlwifi: limit EHT capabilities based on PCIe link speed gregory.greenman
2023-06-20 13:19 ` Ben Greear
2023-06-21 11:57 ` Johannes Berg [this message]
2023-06-21 14:48 ` Ben Greear
2023-06-21 14:51 ` Johannes Berg
2024-10-17 18:55 ` Janusz Dziedzic
2023-06-20 10:03 ` [PATCH 11/19] wifi: iwlwifi: remove disable_dummy_notification gregory.greenman
2023-06-20 10:03 ` [PATCH 12/19] wifi: iwlwifi: mvm: send LARI configuration earlier gregory.greenman
2023-06-20 10:03 ` [PATCH 13/19] wifi: iwlwifi: Add support for new PCI Id gregory.greenman
2023-06-20 10:04 ` [PATCH 14/19] wifi: iwlwifi: mvm: support new flush_sta method gregory.greenman
2023-06-20 10:04 ` [PATCH 15/19] wifi: iwlwifi: mvm: indicate HW decrypt for beacon protection gregory.greenman
2023-06-20 10:04 ` [PATCH 16/19] wifi: iwlwifi: mvm: avoid baid size integer overflow gregory.greenman
2023-06-20 10:04 ` [PATCH 17/19] wifi: iwlwifi: mvm: check only affected links gregory.greenman
2023-06-20 10:04 ` [PATCH 18/19] wifi: iwlwifi: mvm: adjust skip-over-dtim in D3 gregory.greenman
2023-06-20 10:04 ` [PATCH 19/19] wifi: iwlwifi: mvm: Add support for scan version 17 gregory.greenman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53612acba151d031f636626db20c1c60db09fdd0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=gregory.greenman@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox