From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] cfg80211: constify MAC addresses in cfg80211 ops
Date: Tue, 20 May 2014 11:28:30 +0200 [thread overview]
Message-ID: <537B203E.4030501@broadcom.com> (raw)
In-Reply-To: <1400573741.4474.1.camel@jlt4.sipsolutions.net>
On 05/20/14 10:15, Johannes Berg wrote:
> On Tue, 2014-05-20 at 10:13 +0200, Arend van Spriel wrote:
>> On 05/19/14 17:54, Johannes Berg wrote:
>>> From: Johannes Berg<johannes.berg@intel.com>
>>>
>>> This propagates through all the drivers and mac80211.
>>>
>> Acked-by: Arend van Spriel<arend@broadcom.com>
>>> Signed-off-by: Johannes Berg<johannes.berg@intel.com>
>>> ---
>>
>> Should this also be done for the macaddr field in struct vif_params?
>
> That'd be difficult to do since it's a real value, not just a pointer,
> so it must be filled by something :)
True. It should have to use a cast to do that, but that would make the
change rather pointless. Please forget I ever mentioned it :-p
Gr. AvS
prev parent reply other threads:[~2014-05-20 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 15:54 [PATCH 1/2] cfg80211: constify MAC addresses in cfg80211 ops Johannes Berg
2014-05-19 15:54 ` [PATCH 2/2] cfg80211: constify more pointers in the cfg80211 API Johannes Berg
2014-05-20 8:13 ` [PATCH 1/2] cfg80211: constify MAC addresses in cfg80211 ops Arend van Spriel
2014-05-20 8:15 ` Johannes Berg
2014-05-20 9:28 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B203E.4030501@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).