From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>, linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Handle multiple keys while setting tx filters
Date: Wed, 21 May 2014 12:47:34 +0200 [thread overview]
Message-ID: <537C8446.9030807@openwrt.org> (raw)
In-Reply-To: <1400665650-24320-1-git-send-email-rmanohar@qti.qualcomm.com>
On 2014-05-21 11:47, Rajkumar Manoharan wrote:
> The keycache index is used to abort transmission for given station
> when it goes to sleep state. But the commit "ath9k_hw: Abort transmission
> for sleeping station" is not handling multi-key station. Fix that.
>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
The use of num_keys in that patch seems quite wrong (or at least very
fragile) to me, you don't decrement it in the DISABLE_KEY case at all.
Maybe you should just remove it, as it does not really help with
speeding things up in any meaningful way.
Also, please make use of ARRAY_SIZE, so you don't need to hardcode the
array size in multiple places.
- Felix
prev parent reply other threads:[~2014-05-21 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 9:47 [PATCH] ath9k: Handle multiple keys while setting tx filters Rajkumar Manoharan
2014-05-21 10:47 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C8446.9030807@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).