From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lb0-f174.google.com ([209.85.217.174]:43896 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbaFAQiq (ORCPT ); Sun, 1 Jun 2014 12:38:46 -0400 Received: by mail-lb0-f174.google.com with SMTP id n15so2000839lbi.19 for ; Sun, 01 Jun 2014 09:38:45 -0700 (PDT) Message-ID: <538B5714.6060107@cogentembedded.com> (sfid-20140601_183914_333769_8E0FDBF3) Date: Sun, 01 Jun 2014 20:38:44 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Rickard Strandqvist , Larry Finger , Chaoming Li CC: "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: wireless: rtlwifi: rtl8192de: phy.c: Cleaning up uninitialized variables References: <1401626948-16183-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1401626948-16183-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 06/01/2014 04:49 PM, Rickard Strandqvist wrote: > There is a risk that the variable will be used without being initialized. > This was largely found by using a static code analysis program called cppcheck. > Signed-off-by: Rickard Strandqvist > --- > drivers/net/wireless/rtlwifi/rtl8192de/phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c > index 3d1f0dd..66abaf6 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c > @@ -203,11 +203,11 @@ u32 rtl92d_phy_query_bb_reg(struct ieee80211_hw *hw, u32 regaddr, u32 bitmask) > struct rtl_priv *rtlpriv = rtl_priv(hw); > struct rtl_hal *rtlhal = rtl_hal(rtlpriv); > u32 returnvalue, originalvalue, bitshift; > - u8 dbi_direct; > > RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, "regaddr(%#x), bitmask(%#x)\n", > regaddr, bitmask); > if (rtlhal->during_mac1init_radioa || rtlhal->during_mac0init_radiob) { > + u8 dbi_direct = 0; Empty line is needed here, after declarations, like above. > /* mac1 use phy0 read radio_b. */ > /* mac0 use phy1 read radio_b. */ > if (rtlhal->during_mac1init_radioa) WBR, Sergei