From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lb0-f182.google.com ([209.85.217.182]:37276 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752210AbaFATc3 (ORCPT ); Sun, 1 Jun 2014 15:32:29 -0400 Received: by mail-lb0-f182.google.com with SMTP id z11so2012627lbi.41 for ; Sun, 01 Jun 2014 12:32:27 -0700 (PDT) Message-ID: <538B7FCB.5090106@cogentembedded.com> (sfid-20140601_213309_733696_AD0CCEDD) Date: Sun, 01 Jun 2014 23:32:27 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Rickard Strandqvist CC: Larry Finger , Chaoming Li , "John W. Linville" , linux-wireless@vger.kernel.org, Network Development , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] net: wireless: rtlwifi: rtl8192de: phy.c: Cleaning up uninitialized variables References: <1401626948-16183-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <538B5714.6060107@cogentembedded.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 06/01/2014 08:44 PM, Rickard Strandqvist wrote: > Okay, sorry. But you agree with what it is doing in general then? Now that you asked, I do agree. But generally my reply doesn't mean that I went and studied the patch context and verified that the patch is indeed correct. > In this case, I am sending a new patch... BTW, it's worth mentioning in the change log that you're moving the variable in question into the block. > Best regards > Rickard Strandqvist WBR, Sergei