From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] ath10k: provide firmware crash info via debugfs.
Date: Fri, 06 Jun 2014 10:06:35 -0700 [thread overview]
Message-ID: <5391F51B.4020103@candelatech.com> (raw)
In-Reply-To: <87y4xal6vb.fsf@kamboji.qca.qualcomm.com>
On 06/06/2014 02:33 AM, Kalle Valo wrote:
>> + kfree(buffer);
>> + goto save_regs_and_restart;
>> + }
>> +
>> + ath10k_dbg_save_fw_dbg_buffer(ar, buffer,
>> + dbuf.length);
>> + kfree(buffer);
>
> Instead of doing atomic allocations multiple times in a loop, would it
> be better to allocate just one buffer before the loop and free it
> afterwards?
There is no hard guarantee that the buffer lengths are the same,
so I think it needs to remain as is. Would rather not crap out
because firmware suddenly got more clever...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-06-06 17:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 18:01 [PATCH 1/4] ath10k: provide firmware crash info via debugfs greearb
2014-06-04 18:01 ` [PATCH 2/4] ath10k: save firmware debug log messages greearb
2014-06-04 18:01 ` [PATCH 3/4] ath10k: save firmware stack upon firmware crash greearb
2014-06-04 18:01 ` [PATCH 4/4] ath10k: Dump exception stack contents on " greearb
2014-06-05 16:18 ` [PATCH 1/4] ath10k: provide firmware crash info via debugfs Kalle Valo
2014-06-05 18:25 ` Ben Greear
2014-06-06 6:10 ` Kalle Valo
2014-06-06 6:30 ` Michal Kazior
2014-06-06 8:55 ` Kalle Valo
2014-06-06 9:45 ` Michal Kazior
2014-06-06 16:11 ` Ben Greear
2014-06-07 12:55 ` Kalle Valo
2014-06-07 15:32 ` Ben Greear
2014-06-08 8:28 ` Kalle Valo
2014-06-08 15:40 ` Ben Greear
2014-06-06 6:55 ` Kalle Valo
2014-06-06 16:01 ` Ben Greear
2014-06-07 12:50 ` Kalle Valo
2014-06-06 9:33 ` Kalle Valo
2014-06-06 17:06 ` Ben Greear [this message]
2014-06-07 12:57 ` Kalle Valo
2014-06-07 15:29 ` Ben Greear
2014-06-08 8:12 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5391F51B.4020103@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).