From: Arend van Spriel <arend@broadcom.com>
To: "Emmanuel Grumbach" <egrumbach@gmail.com>,
"Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
<b43-dev@lists.infradead.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [RFC: which stable kernels?] b43: fix frequency reported on G-PHY with /new/ firmware
Date: Thu, 12 Jun 2014 09:43:27 +0200 [thread overview]
Message-ID: <53995A1F.6000405@broadcom.com> (raw)
In-Reply-To: <CANUX_P1RA6PUDiFrT0wta57BNW9oRVAkNstT5ieiBjA9sHWnfw@mail.gmail.com>
On 12-06-14 09:35, Emmanuel Grumbach wrote:
>> ---
>> This bug was there for years, however didn't cause any problems. It was
>> exposed recently by the 3.15 release by the:
>>
>> commit 3afc2167f60a327a2c1e1e2600ef209a3c2b75b7
>> Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>> Date: Tue Mar 4 16:50:13 2014 +0200
>>
>> cfg80211/mac80211: ignore signal if the frame was heard on wrong channel
>>
>> Should we mark it for stable for 3.15 only? Or all olders kernels as well?
>
> Up to you - my patch is in 3.15 only I think.
Is there any scenario that would expose the worng info. Maybe when using
monitor mode?
Gr. AvS
>> ---
>> drivers/net/wireless/b43/xmit.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/xmit.c b/drivers/net/wireless/b43/xmit.c
>> index 4f38f19..6e6ef3f 100644
>> --- a/drivers/net/wireless/b43/xmit.c
>> +++ b/drivers/net/wireless/b43/xmit.c
>> @@ -811,9 +811,13 @@ void b43_rx(struct b43_wldev *dev, struct sk_buff *skb, const void *_rxhdr)
>> break;
>> case B43_PHYTYPE_G:
>> status.band = IEEE80211_BAND_2GHZ;
>> - /* chanid is the radio channel cookie value as used
>> - * to tune the radio. */
>> - status.freq = chanid + 2400;
>> + /* Somewhere between 478.104 and 508.1084 firmware for G-PHY
>> + * has been modified to be compatible with N-PHY and others.
>> + */
>> + if (dev->fw.rev >= 508)
>> + status.freq = ieee80211_channel_to_frequency(chanid, status.band);
>> + else
>> + status.freq = chanid + 2400;
>> break;
>> case B43_PHYTYPE_N:
>> case B43_PHYTYPE_LP:
>> --
>> 1.8.4.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-06-12 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 7:28 [RFC: which stable kernels?] b43: fix frequency reported on G-PHY with /new/ firmware Rafał Miłecki
2014-06-12 7:35 ` Emmanuel Grumbach
2014-06-12 7:43 ` Arend van Spriel [this message]
2014-06-12 12:43 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53995A1F.6000405@broadcom.com \
--to=arend@broadcom.com \
--cc=aaro.koskinen@iki.fi \
--cc=b43-dev@lists.infradead.org \
--cc=egrumbach@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).