From: Felix Fietkau <nbd@openwrt.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev <b43-dev@lists.infradead.org>
Subject: Re: [PATCH 1/2] b43: remove leftover code from old devices support
Date: Sun, 22 Jun 2014 16:10:41 +0200 [thread overview]
Message-ID: <53A6E3E1.3090501@openwrt.org> (raw)
In-Reply-To: <CACna6ryCRraViALRp5fMfmJzYDTQ+6OUuJnRGRj5i5v36Ntw4A@mail.gmail.com>
On 2014-06-22 16:07, Rafał Miłecki wrote:
> On 22 June 2014 14:14, Felix Fietkau <nbd@openwrt.org> wrote:
>> On 2014-06-20 17:22, Rafał Miłecki wrote:
>>> Old devices (A-PHY or B-PHY) are supposed to be supported by b43legacy.
>>> We keep phy_a.c as it's needed for G-PHY which shares some design.
>>>
>>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> Wouldn't it make sense to move the relevant pieces of phy_a.c to phy_g.c
>> and then remove phy_a.c entirely?
>>
>> There are pieces in phy_a.c which can be removed entirely, e.g.
>> b43_phyops_a and things only used by this struct.
>
> Absolutely, however it needs some effort and time. I'm currently quite
> busy with other things in b43.
>
> One could remove b43_phyops_a, then remove newly-unused functions.
> Then see what code is not used by G-PHY. However you should keep in
> mind, that 5 GHz support for G-PHY may need some functions that are
> not called at this moment. So I'd suggest looking at 5 GHz support in
> G-PHY first to avoid removing sth that may be needed in the future.
Makes sense.
- Felix
prev parent reply other threads:[~2014-06-22 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 15:22 [PATCH 1/2] b43: remove leftover code from old devices support Rafał Miłecki
2014-06-20 15:22 ` [PATCH 2/2] b43: add config for (en|dis)abling G-PHY support Rafał Miłecki
2014-06-22 12:14 ` [PATCH 1/2] b43: remove leftover code from old devices support Felix Fietkau
2014-06-22 14:07 ` Rafał Miłecki
2014-06-22 14:10 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A6E3E1.3090501@openwrt.org \
--to=nbd@openwrt.org \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).