Can we make ieee80211_iface_combination.limits non-const?

Can we make ieee80211_iface_combination.limits non-const?

[Ben Greear]

Depending on firmware loaded (and/or module options), a different
number of vdev interfaces may be supported.

Can we remove the const from the "struct ieee80211_iface_limit *limits"
member of ieee80211_iface_combination?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: Can we make ieee80211_iface_combination.limits non-const?

[Johannes Berg]

On Thu, 2014-06-26 at 11:20 -0700, Ben Greear wrote:
> Depending on firmware loaded (and/or module options), a different
> number of vdev interfaces may be supported.
> 
> Can we remove the const from the "struct ieee80211_iface_limit *limits"
> member of ieee80211_iface_combination?

No, it would break drivers who actually have a static const for the
pointer target.

You don't have to assign something that's const, but you also can't be
changing it on the fly after wiphy registration anyway.

johannes

Re: Can we make ieee80211_iface_combination.limits non-const?

[Ben Greear]

On 06/26/2014 01:06 PM, Johannes Berg wrote:
> On Thu, 2014-06-26 at 11:20 -0700, Ben Greear wrote:
>> Depending on firmware loaded (and/or module options), a different
>> number of vdev interfaces may be supported.
>>
>> Can we remove the const from the "struct ieee80211_iface_limit *limits"
>> member of ieee80211_iface_combination?
> 
> No, it would break drivers who actually have a static const for the
> pointer target.

That could be easily fixed, eh?

> You don't have to assign something that's const, but you also can't be
> changing it on the fly after wiphy registration anyway.

This would be done before registration.  I like static init
for defaults, but wanted to poke a few variables at run-time
based on firmware, etc.

Thanks,
Ben

> 
> johannes
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: Can we make ieee80211_iface_combination.limits non-const?

[Johannes Berg]

On Thu, 2014-06-26 at 13:23 -0700, Ben Greear wrote:
> On 06/26/2014 01:06 PM, Johannes Berg wrote:
> > On Thu, 2014-06-26 at 11:20 -0700, Ben Greear wrote:
> >> Depending on firmware loaded (and/or module options), a different
> >> number of vdev interfaces may be supported.
> >>
> >> Can we remove the const from the "struct ieee80211_iface_limit *limits"
> >> member of ieee80211_iface_combination?
> > 
> > No, it would break drivers who actually have a static const for the
> > pointer target.
> 
> That could be easily fixed, eh?

Yeah but it'd be stupid :)

> > You don't have to assign something that's const, but you also can't be
> > changing it on the fly after wiphy registration anyway.
> 
> This would be done before registration.  I like static init
> for defaults, but wanted to poke a few variables at run-time
> based on firmware, etc.

I don't really get it anyway. If you're going to do anything dynamic,
you don't want to be changing a global static value anyway. You want to
be making a copy or so and building it in a dynamic data structure, and
then point to it.

johannes