From: Varka Bhadram <varkabhadram@gmail.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: extend debug code for RX path
Date: Mon, 28 Jul 2014 12:05:31 +0530 [thread overview]
Message-ID: <53D5EF33.1080208@gmail.com> (raw)
In-Reply-To: <1406528765-4669-1-git-send-email-janusz.dziedzic@tieto.com>
On 07/28/2014 11:56 AM, Janusz Dziedzic wrote:
> Print sequence number, AMSDU_MORE flag and AC when additional
> debug enabled in RX path. This is usefull for debugging purpose.
>
> Signed-off-by: Janusz Dziedzic<janusz.dziedzic@tieto.com>
> ---
> drivers/net/wireless/ath/ath10k/htt_rx.c | 41 ++++++++++++++++++++++++++++--
> 1 file changed, 39 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> index d80fcda..f7c8021 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -818,19 +818,55 @@ static bool ath10k_htt_rx_h_channel(struct ath10k *ar,
> return true;
> }
>
> +static const char * const tid_to_ac[] = {
No space required '*' and const.
static const char *const tid_to_ac[] = {
> + "BE",
> + "BK",
> + "BK",
> + "BE",
> + "VI",
> + "VI",
> + "VO",
> + "VO",
> +};
> +
> +static char *ath10k_get_tid(struct ieee80211_hdr *hdr, char *out, size_t size)
> +{
> + u8 *qc;
> + int tid;
> +
> + if (!ieee80211_is_data_qos(hdr->frame_control))
> + return "";
return NULL would be more readable...?
> +
> + qc = ieee80211_get_qos_ctl(hdr);
> + tid = *qc & IEEE80211_QOS_CTL_TID_MASK;
> + if (tid < 8)
> + snprintf(out, size, "tid %d (%s)", tid, tid_to_ac[tid]);
> + else
> + snprintf(out, size, "tid %d", tid);
> +
> + return out;
> +}
> +
> static void ath10k_process_rx(struct ath10k *ar,
> struct ieee80211_rx_status *rx_status,
> struct sk_buff *skb)
> {
> struct ieee80211_rx_status *status;
> + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
> + char tid[32];
>
> status = IEEE80211_SKB_RXCB(skb);
> *status = *rx_status;
>
> ath10k_dbg(ATH10K_DBG_DATA,
> - "rx skb %p len %u %s%s%s%s%s %srate_idx %u vht_nss %u freq %u band %u flag 0x%x fcs-err %imic-err %i\n",
> + "rx skb %p len %u peer %pM %s %s sn %u %s%s%s%s%s %srate_idx %u vht_nss %u freq %u band %u flag 0x%x fcs-err %i mic-err %i amsdu-more %i\n",
> skb,
> skb->len,
> + ieee80211_get_SA(hdr),
> + ath10k_get_tid(hdr, tid, sizeof(tid)),
> + is_multicast_ether_addr(ieee80211_get_DA(hdr)) ?
> + "mcast" : "ucast",
should match open paranthesis...
is_multicast_ether_addr(ieee80211_get_DA(hdr)) ?
"mcast" : "ucast",
> + (__le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4,
> status->flag == 0 ? "legacy" : "",
> status->flag & RX_FLAG_HT ? "ht" : "",
> status->flag & RX_FLAG_VHT ? "vht" : "",
> @@ -842,7 +878,8 @@ static void ath10k_process_rx(struct ath10k *ar,
> status->freq,
> status->band, status->flag,
> !!(status->flag & RX_FLAG_FAILED_FCS_CRC),
> - !!(status->flag & RX_FLAG_MMIC_ERROR));
> + !!(status->flag & RX_FLAG_MMIC_ERROR),
> + !!(status->flag & RX_FLAG_AMSDU_MORE));
> ath10k_dbg_dump(ATH10K_DBG_HTT_DUMP, NULL, "rx skb: ",
> skb->data, skb->len);
>
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-07-28 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 6:26 [PATCH v2] ath10k: extend debug code for RX path Janusz Dziedzic
2014-07-28 6:35 ` Varka Bhadram [this message]
2014-07-28 7:52 ` Janusz Dziedzic
2014-07-28 8:07 ` Kalle Valo
2014-07-29 9:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D5EF33.1080208@gmail.com \
--to=varkabhadram@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).