Re: [PATCH] carl9170: fix sending URBs with wrong type when using full-speed

[Ronald Wahl <ronald.wahl@raritan.com>]

On 07.08.2014 11:33, Ronald Wahl wrote:
> On 07.08.2014 11:24, Ronald Wahl wrote:
>> +    /* We need to remember the type of endpoint 4 because it differs
>> +     * between high- and full-speed configuration. The high-speed
>> +     * configuration specifies it as interrupt and the full-speed
>> +     * configuration as bulk endpoint. This information is required
>> +     * later when sending urbs to that endpoint.
>> +     */
>> +    for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; ++i) {
>> +        ep = &intf->cur_altsetting->endpoint[i].desc;
>> +
>> +        if (usb_endpoint_dir_out(ep) && usb_endpoint_num(ep) == 4)
>> +            ar->usb_ep4_is_bulk = true;
>> +    }
>
> Hi,
>
> just after sending out that patch I have seen that I should better use
> AR9170_USB_EP_CMD instead of 4 when checking for the endpoint and maybe
> rename the flag into usb_ep_cmd_is_bulk. But before creating v2 of the
> patch I want to hear your comments...

A fellow just pointed out that a central part of my patch was wrong as I 
actually forgot to check the endpoint type and instead hardcoded the 
result. So I had to create v2 of the patch now.

Mea culpa,
ron

-- 
Ronald Wahl - ronald.wahl@raritan.com - Phone +49 375271349-0 Fax -99
Raritan Deutschland GmbH, Kornmarkt 7, 08056 Zwickau, Germany
USt-IdNr. DE813094160, Steuer-Nr. 227/117/01749
Amtsgericht Chemnitz HRB 23605
Geschäftsführung: Stuart Hopper, Ralf Ploenes