From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: remove @gfp parameter from cfg80211_rx_mgmt()
Date: Tue, 12 Aug 2014 10:24:00 +0200 [thread overview]
Message-ID: <53E9CF20.8030500@broadcom.com> (raw)
In-Reply-To: <1407769025.9844.0.camel@jlt4.sipsolutions.net>
On 08/11/2014 04:57 PM, Johannes Berg wrote:
> On Mon, 2014-08-11 at 03:29 -0700, Vladimir Kondratiev wrote:
>> In the cfg80211_rx_mgmt(), parameter @gfp was used for the memory allocation.
>> But, memory get allocated under spin_lock_bh(), this implies atomic context.
>> So, one can't use GFP_KERNEL, only variants with no __GFP_WAIT. Actually, in all
>> occurrences GFP_ATOMIC is used (wil6210 use GFP_KERNEL by mistake),
>> and it should be this way or warning triggered in the memory allocation code.
>>
>> Remove @gfp parameter as no actual choice exist, and use hard coded
>> GFP_ATOMIC for memory allocation.
When I saw the patch I quickly checked and noticed brcmfmac using
GFP_ATOMIC. However, looking at bit closer into this it turns out that
the cfg80211_rx_mgmt() call could be done with GFP_KERNEL flag in
brcmfmac. I leave it to you what to do here :-p
> Applied, thanks.
>
> johannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-08-12 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 10:29 [PATCH] cfg80211: remove @gfp parameter from cfg80211_rx_mgmt() Vladimir Kondratiev
2014-08-11 14:57 ` Johannes Berg
2014-08-12 8:24 ` Arend van Spriel [this message]
2014-08-12 8:31 ` Johannes Berg
2014-08-12 9:07 ` Vladimir Kondratiev
2014-08-12 9:16 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E9CF20.8030500@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=qca_vkondrat@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).