From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>
Cc: <kvalo@adurom.com>, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 2/2] cfg80211: allow passing frame type to cfg80211_inform_bss()
Date: Thu, 14 Aug 2014 11:23:59 +0200 [thread overview]
Message-ID: <53EC802F.3020805@broadcom.com> (raw)
In-Reply-To: <1407870219-1720-2-git-send-email-johannes@sipsolutions.net>
On 08/12/2014 09:03 PM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> When using the cfg80211_inform_bss[_width]() functions drivers
> cannot currently indicate whether the data was received in a
> beacon or probe response. Fix that by passing a new enum that
> indicates such (or unknown).
>
> For good measure, use it in ath6kl.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/net/wireless/ath/ath6kl/cfg80211.c | 1 +
> drivers/net/wireless/ath/ath6kl/wmi.c | 43 +++++-----------------
> drivers/net/wireless/ath/wil6210/wmi.c | 2 +-
> .../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 18 ++++++---
> drivers/net/wireless/libertas/cfg.c | 2 +
> drivers/net/wireless/mwifiex/cfg80211.c | 1 +
> drivers/net/wireless/mwifiex/scan.c | 3 +-
> drivers/net/wireless/orinoco/scan.c | 14 ++++---
> drivers/net/wireless/rndis_wlan.c | 14 ++++---
> drivers/staging/wlan-ng/cfg80211.c | 1 +
> include/net/cfg80211.h | 20 +++++++++-
> net/wireless/scan.c | 21 ++++++++---
> 12 files changed, 78 insertions(+), 62 deletions(-)
[...]
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> index d8fa276e368b..9a45ef064dd9 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> @@ -2429,9 +2429,13 @@ static s32 brcmf_inform_single_bss(struct brcmf_cfg80211_info *cfg,
> brcmf_dbg(CONN, "Beacon interval: %d\n", notify_interval);
> brcmf_dbg(CONN, "Signal: %d\n", notify_signal);
>
> - bss = cfg80211_inform_bss(wiphy, notify_channel, (const u8 *)bi->BSSID,
> - 0, notify_capability, notify_interval, notify_ie,
> - notify_ielen, notify_signal, GFP_KERNEL);
> + bss = cfg80211_inform_bss(wiphy, notify_channel,
> + CFG80211_BSS_FTYPE_UNKNOWN,
Checked the firmware API and it does not provide this info.
Acked-by: Arend van Spriel <arend@broadcom.com>
Regards,
Arend
next prev parent reply other threads:[~2014-08-14 9:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 19:03 [PATCH 1/2] cfg80211: clarify BSS probe response vs. beacon data Johannes Berg
2014-08-12 19:03 ` [PATCH 2/2] cfg80211: allow passing frame type to cfg80211_inform_bss() Johannes Berg
2014-08-14 8:57 ` Kalle Valo
2014-08-14 9:23 ` Arend van Spriel [this message]
2014-08-13 10:57 ` [PATCH 1/2] cfg80211: clarify BSS probe response vs. beacon data Eliad Peller
2014-08-13 11:08 ` Johannes Berg
2014-08-13 11:13 ` Eliad Peller
2014-08-13 11:20 ` Johannes Berg
2014-08-13 11:39 ` Eliad Peller
2014-08-13 11:46 ` Johannes Berg
2014-08-13 11:57 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EC802F.3020805@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).