From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] cfg80211: Reorder wiphy_register/unregister() notifications relevantly
Date: Fri, 29 Aug 2014 14:28:56 +0300 [thread overview]
Message-ID: <540063F8.30200@linux.intel.com> (raw)
In-Reply-To: <1409310627.4577.17.camel@jlt4.sipsolutions.net>
Hi Johannes,
>> >+ cfg80211_debugfs_rdev_add(rdev);
>> >+ rtnl_unlock();
> I'm not convinced that it's safe to drop the rtnl here, when we only
> later set wiphy.registered = true.
>
> As is, the wiphy would end up on the list, but not registered - yet in
> this period it would be reachable for example for nl80211 commands in
> the unregistered state. This seems wrong.
Ok, I counted on the fact the device is not yet advertized as being
ready (the NEW_WIPHY below).
Will see how to avoid this early unlock.
> Additionally, maybe add a brief note regarding the second part of the
> patch (checking registered in unregister) to the commit log?
Sure.
Tomasz
prev parent reply other threads:[~2014-08-29 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 9:35 [PATCH v3] cfg80211: Reorder wiphy_register/unregister() notifications relevantly Tomasz Bursztyka
2014-08-29 11:10 ` Johannes Berg
2014-08-29 11:28 ` Tomasz Bursztyka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540063F8.30200@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).