Re: [PATCH] Revert "ath9k: Calculate sleep duration"

[Oleksij Rempel <linux@rempel-privat.de>]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

Am 12.09.2014 um 08:09 schrieb Rajkumar Manoharan:
> On Thu, Sep 11, 2014 at 07:56:31PM +0530, Sujith Manoharan wrote:
>> Rajkumar Manoharan wrote:
>>> Some of the IOE customer using ath9k with power save enabled. IIRC the
>>> expectation is that when the station is idle, it should wakeup on DTIM
>>> beacon not for every beacons. Are you seeing frequest bmiss events on
>>> higher beacon interval?
>>
>> I don't think ath9k has ever been tested with longer sleep durations
>> based on dtim period. We have always programmed the hardware to wake up
>> for every beacon interval, using the TIM_TIMER interrupt. And since the
>> TIM bit needs to be checked for every beacon, the sleep duration has
>> to be the beacon interval.
>>
>> Also, the bmiss threshold needs to be adjusted based on the sleep
>> duration. We are hardcoding it currently in the driver using
>> ATH_DEFAULT_BMISS_LIMIT. This will break, too.
>>
>> Using dtim for PS needs more testing before it can be used,
>> so we can have the original behavior for now.
>>
> Sounds clear.
> 
> Acked-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>

Just bisected that this patch caused kernel panic on ath9k_htc.
One more reason for revert ;)

-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]