From: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Rosen Penev <rosenp@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: wfx: handle EPROBE_DEFER with of_get_mac_address
Date: Mon, 27 Apr 2026 09:49:08 +0200 [thread overview]
Message-ID: <5416906.31r3eYUQgx@nb0018864> (raw)
In-Reply-To: <20260427051604.953450-1-rosenp@gmail.com>
Hello Rosen,
On Monday 27 April 2026 07:16:04 Central European Summer Time Rosen Penev wrote:
>
> In case nvmem gets used and is not ready in time for probe of wfx,
> EPROBE_DEFER gets called. Return it so that a proper MAC address can be
> specified in such a case.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/wireless/silabs/wfx/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/silabs/wfx/main.c b/drivers/net/wireless/silabs/wfx/main.c
> index dda36e41eed1..dc40a9bd986d 100644
> --- a/drivers/net/wireless/silabs/wfx/main.c
> +++ b/drivers/net/wireless/silabs/wfx/main.c
> @@ -445,6 +445,8 @@ int wfx_probe(struct wfx_dev *wdev)
> for (i = 0; i < ARRAY_SIZE(wdev->addresses); i++) {
> eth_zero_addr(wdev->addresses[i].addr);
> err = of_get_mac_address(wdev->dev->of_node, wdev->addresses[i].addr);
> + if (err == -EPROBE_DEFER)
> + goto irq_unsubscribe;
> if (!err)
> wdev->addresses[i].addr[ETH_ALEN - 1] += i;
> else
I assume this patch works when WF200 is connected on SPI with reset GPIO
configured. However, for SDIO and without gpio reset, we can't run the
device initialisation twice.
I believe the check has to happen before the call to wfx_init_device().
To check it works as expected, can you also test your patch without the
reset-gpio attribute?
--
Jérôme Pouiller
next prev parent reply other threads:[~2026-04-27 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 5:16 [PATCH] wifi: wfx: handle EPROBE_DEFER with of_get_mac_address Rosen Penev
2026-04-27 7:49 ` Jérôme Pouiller [this message]
2026-04-27 19:31 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416906.31r3eYUQgx@nb0018864 \
--to=jerome.pouiller@silabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox