From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/9] ath10k: fix tx/rx chainmask init
Date: Thu, 18 Sep 2014 09:11:49 -0700 [thread overview]
Message-ID: <541B0445.7040707@candelatech.com> (raw)
In-Reply-To: <1411046487-19544-2-git-send-email-michal.kazior@tieto.com>
On 09/18/2014 06:21 AM, Michal Kazior wrote:
> Firmware reports the number of RF chains so use
> that for initialization of supp_{tx,rx}_chainmask
> instead of using a macro for 3x3 chips.
>
> This should make tx/rx chainmask reports correct
> for chips other than 3x3.
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> index 2c42bd5..772cca5 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -2198,6 +2198,9 @@ static void ath10k_wmi_service_ready_event_rx(struct ath10k *ar,
> ar->num_rf_chains = WMI_MAX_SPATIAL_STREAM;
> }
>
> + ar->supp_tx_chainmask = (1 << ar->num_rf_chains) - 1;
> + ar->supp_rx_chainmask = (1 << ar->num_rf_chains) - 1;
Are there are no chips that support a different number
of tx and rx chains?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-09-18 16:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 13:21 [PATCH 0/9] ath10k: mostly cleanups Michal Kazior
2014-09-18 13:21 ` [PATCH 1/9] ath10k: fix tx/rx chainmask init Michal Kazior
2014-09-18 16:11 ` Ben Greear [this message]
2014-09-19 5:59 ` Michal Kazior
2014-09-18 13:21 ` [PATCH 2/9] ath10k: remove unused pdev_set_channel command Michal Kazior
2014-09-18 13:21 ` [PATCH 3/9] ath10k: deduplicate wmi_channel code Michal Kazior
2014-09-18 13:21 ` [PATCH 4/9] ath10k: deduplicate host mem chunk code Michal Kazior
2014-09-18 13:21 ` [PATCH 5/9] ath10k: relocate wmi attach/deatch functions Michal Kazior
2014-09-18 13:21 ` [PATCH 6/9] ath10k: deduplicate wmi service ready logic Michal Kazior
2014-09-19 8:37 ` Kalle Valo
2014-09-19 8:43 ` Michal Kazior
2014-09-22 9:46 ` Kalle Valo
2014-09-22 10:33 ` Michal Kazior
2014-09-18 13:21 ` [PATCH 7/9] ath10k: clean up phyerr code Michal Kazior
2014-09-18 13:21 ` [PATCH 8/9] ath10k: unify wmi event function names Michal Kazior
2014-09-18 13:21 ` [PATCH 9/9] ath10k: re-work scan start command building Michal Kazior
2014-09-23 9:33 ` [PATCH 0/9] ath10k: mostly cleanups Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B0445.7040707@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).