From: Arend van Spriel <arend@broadcom.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>,
<linux-wireless@vger.kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: allow to configure dynamic PS timeout
Date: Tue, 30 Sep 2014 16:05:07 +0200 [thread overview]
Message-ID: <542AB893.9090201@broadcom.com> (raw)
In-Reply-To: <542AB859.5080008@broadcom.com>
On 30-09-14 16:04, Arend van Spriel wrote:
> On 30-09-14 15:18, Stanislaw Gruszka wrote:
>> Dynamic power save timeout value is suppose to be configurable via
>> wext, but due to iwconfig bug is not possible to set it using that tool.
>>
>> Allow to configure PS timeout via nl80211 - add NL80211_ATTR_PS_TIMEOUT
>> attribute which become timeout stated in ms.
>>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>> ---
>> include/uapi/linux/nl80211.h | 2 ++
>> net/wireless/nl80211.c | 21 +++++++++++++++++----
>> 2 files changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
>> index 4b28dc0..600d47b 100644
>> --- a/include/uapi/linux/nl80211.h
>> +++ b/include/uapi/linux/nl80211.h
>> @@ -1990,6 +1990,8 @@ enum nl80211_attrs {
>>
>> NL80211_ATTR_SMPS_MODE,
>>
>> + NL80211_ATTR_PS_TIMEOUT,
>> +
>
> Isn't there some doxygen comment where this new attribute should be
> described?
Uuuhmm, I mean kerneldoc, of course!
> Regards,
> Arend
>
next prev parent reply other threads:[~2014-09-30 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 13:18 [PATCH] cfg80211: allow to configure dynamic PS timeout Stanislaw Gruszka
2014-09-30 14:04 ` Arend van Spriel
2014-09-30 14:05 ` Arend van Spriel [this message]
2014-10-01 9:27 ` [PATCH v2] " Stanislaw Gruszka
2014-10-06 15:00 ` Johannes Berg
2014-10-07 11:03 ` Stanislaw Gruszka
2014-10-07 12:05 ` Johannes Berg
2014-10-07 12:32 ` Krishna Chaitanya
2014-10-07 12:47 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542AB893.9090201@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).