Re: [PATCH v2 1/4] wireless: expose set-wiphy-name method to other modules.

[Ben Greear <greearb@candelatech.com>]

On 10/06/2014 07:27 AM, Johannes Berg wrote:
> On Fri, 2014-09-26 at 16:24 -0700, greearb@candelatech.com wrote:
>
>> +/*
>> + * Attempt to rename a device.  Acquire RTNL before calling.
>> + */
>
> please add kernel-doc
>
>> +int cfg80211_dev_rename_wiphy(struct wiphy *wiphy, char *newname);
>
> Should also be const char *
>
> And should probably be called cfg80211_rename_wiphy() only? What's the
> dev doing there?
>>
>> +int cfg80211_dev_rename_wiphy(struct wiphy *wiphy, char *newname)
>> +{
>> +	struct cfg80211_registered_device *rdev;
>> +
>> +	rdev = wiphy_to_rdev(wiphy);
>> +	return cfg80211_dev_rename(rdev, newname);
>
> You could just inlin ethe wiphy_to_rdev() and get rid of the variable.
>
> Anyhow - if the intent is to do this at creation, why do you do it after
> the fact? Couldn't you just specify the name when creating it?

That would be fine with me..I thought it might be more invasive
and thus less welcome.  I'll see what it takes to implement it
like that when I get a chance.  On the road this week, so might
be a bit...

Thanks,
Ben

>
> johannes
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com