From: Arend van Spriel <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
Maximilian Engelhardt <maxi@daemonizer.de>,
Seth Forshee <seth.forshee@canonical.com>,
"brcm80211 development" <brcm80211-dev-list@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH][RTF][RFC] brcmsmac: add workaround for old BCM4313 devices with Bluetooth
Date: Thu, 9 Oct 2014 12:46:25 +0200 [thread overview]
Message-ID: <54366781.8090005@broadcom.com> (raw)
In-Reply-To: <CACna6ryEoBYKoRvA7WKJLYva_oUkY+rMjkgo_wj66WhGkxXpgg@mail.gmail.com>
On 10/09/14 12:37, Rafał Miłecki wrote:
> On 9 October 2014 12:28, Michael Tokarev<mjt@tls.msk.ru> wrote:
>> 09.10.2014 14:22, Arend van Spriel wrote:
>>> I know where the function should be called according our driver and guess what:
>>>
>>> if (bfl& BFL_FEM&& chip == 4313) {
>>
>> Can you fix whitespace there too, and add parens around the& operation, while at it?
>
> I think you didn't realize it's a pseudo-code / reference ;)
Indeed or just me being lazy :-p
Regards,
Arend
next prev parent reply other threads:[~2014-10-09 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 8:37 [PATCH][RTF][RFC] brcmsmac: add workaround for old BCM4313 devices with Bluetooth Rafał Miłecki
2014-10-09 9:02 ` Rafał Miłecki
2014-10-09 9:46 ` Arend van Spriel
2014-10-09 10:11 ` Rafał Miłecki
2014-10-09 10:22 ` Arend van Spriel
2014-10-09 10:28 ` Michael Tokarev
2014-10-09 10:37 ` Rafał Miłecki
2014-10-09 10:46 ` Arend van Spriel [this message]
2014-10-09 10:46 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54366781.8090005@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maxi@daemonizer.de \
--cc=mjt@tls.msk.ru \
--cc=seth.forshee@canonical.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).