From: Felix Fietkau <nbd@openwrt.org>
To: Karl Beldan <karl.beldan@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Karl Beldan <karl.beldan@rivierawaves.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 4/4] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz
Date: Sat, 18 Oct 2014 11:29:05 +0200 [thread overview]
Message-ID: <544232E1.3000005@openwrt.org> (raw)
In-Reply-To: <1413575459-29612-5-git-send-email-karl.beldan@gmail.com>
On 2014-10-17 21:50, Karl Beldan wrote:
> From: Karl Beldan <karl.beldan@rivierawaves.com>
>
> When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'),
> there is no behavioral change including in sampling and MCS_GROUP_RATES
> remains 8.
> Otherwise MCS_GROUP_RATES is 10, and a module parameter *vht_only*
> (default 'true'), restricts the rates selection to VHT when vht is
> supported.
>
> Regarding the debugfs stats buffer:
> It is explicitly increased from 8k to 32k to fit every rates incl. when
> both ht and vht rates are enabled, as for the format, before:
> type rate tpt eprob *prob ret *ok(*cum) ok( cum)
> HT20/LGI ABCDP MCS0 0.0 0.0 0.0 1 0( 0) 0( 0)
> after:
> type rate tpt eprob *prob ret *ok(*cum) ok( cum)
> HT20/LGI ABCDP MCS0 0.0 0.0 0.0 1 0( 0) 0( 0)
> VHT40/LGI MCS5/2 0.0 0.0 0.0 0 0( 0) 0( 0)
>
> Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
Aside from the module parameter issue that you already pointed out, the
series looks good to me.
- Felix
next prev parent reply other threads:[~2014-10-18 9:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1413570896-27740-5-git-send-email-karl.beldan@gmail.com>
2014-10-17 19:50 ` [RESEND PATCH v2 0/4] add VHT support to minstrel_ht Karl Beldan
2014-10-17 19:50 ` [RESEND PATCH v2 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes Karl Beldan
2014-10-17 19:50 ` [RESEND PATCH v2 2/4] mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs Karl Beldan
2014-10-17 19:50 ` [RESEND PATCH v2 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag Karl Beldan
2014-10-17 19:50 ` [RESEND PATCH v2 4/4] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz Karl Beldan
2014-10-18 7:57 ` Karl Beldan
2014-10-18 9:29 ` Felix Fietkau [this message]
2014-10-18 17:13 ` [PATCH v3 0/4] add VHT support to minstrel_ht Karl Beldan
2014-10-18 17:13 ` [PATCH v3 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes Karl Beldan
2014-10-18 17:13 ` [PATCH v3 2/4] mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs Karl Beldan
2014-10-18 17:13 ` [PATCH v3 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag Karl Beldan
2014-10-18 17:13 ` [PATCH v3 4/4] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz Karl Beldan
2014-10-20 8:55 ` [PATCH v4 0/4] add VHT support to minstrel_ht Karl Beldan
2014-10-20 8:55 ` [PATCH v4 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes Karl Beldan
2014-10-20 8:55 ` [PATCH v4 2/4] mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs Karl Beldan
2014-10-20 8:55 ` [PATCH v4 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag Karl Beldan
2014-10-20 8:55 ` [PATCH v4 4/4] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz Karl Beldan
2014-10-20 9:01 ` [PATCH v4 0/4] add VHT support to minstrel_ht Varka Bhadram
2014-10-20 9:40 ` Karl Beldan
2014-10-20 9:02 ` Karl Beldan
2014-10-18 17:29 ` [PATCH v3 " Felix Fietkau
2014-10-18 17:41 ` Krishna Chaitanya
2014-10-18 22:19 ` Karl Beldan
2014-10-24 12:43 ` Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544232E1.3000005@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=karl.beldan@gmail.com \
--cc=karl.beldan@rivierawaves.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).