From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 03/10] ath9k: fix processing RXORN interrupts
Date: Mon, 20 Oct 2014 11:01:32 +0200 [thread overview]
Message-ID: <5444CF6C.8050208@openwrt.org> (raw)
In-Reply-To: <21572.50341.631533.278980@gargle.gargle.HOWL>
On 2014-10-20 10:15, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> The "goto chip_reset" is a bit misleading, because it does not actually
>> issue a chip reset. Instead it is bypassing processing of other
>> interrupts and assumes that the tasklet will issue a chip reset.
>
> Well, we kill interrupts and the tasklet sets ATH_OP_HW_RESET,
> so no more interrupts will be processed in ath_isr(), so this
> is a fair assumption.
Except it only does that for FATAL, not RXORN.
>> In the case of RXORN this does not happen, so bypassing processing of
>> other interrupts will simply allow them to fire again. Even if RXORN
>> was triggering a reset, it is not critical enough to need the bypass
>> here.
>
> Wouldn't this be fixed by just processing RXORN in the tasklet,
> along with FATAL ? Or are you saying that RXORN doesn't need a
> chip reset in both edma/legacy, since the edma check has been dropped ?
I'm not sure if we should actually do the chip reset for RXORN, but even
if we should, we don't need this 'goto chip_reset' in ath_isr.
- Felix
next prev parent reply other threads:[~2014-10-20 9:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 17:02 [PATCH 01/10] ath9k_hw: make support for PC-OEM cards optional Felix Fietkau
2014-10-18 17:02 ` [PATCH 02/10] ath9k_hw: remove support for UB124 tx gain table Felix Fietkau
2014-10-20 7:58 ` Sujith Manoharan
2014-10-20 8:54 ` Felix Fietkau
2014-10-18 17:02 ` [PATCH 03/10] ath9k: fix processing RXORN interrupts Felix Fietkau
2014-10-20 8:15 ` Sujith Manoharan
2014-10-20 9:01 ` Felix Fietkau [this message]
2014-10-18 17:02 ` [PATCH 04/10] ath9k: clean up debugfs print of reset causes Felix Fietkau
2014-10-18 17:02 ` [PATCH 05/10] ath9k: restart hardware after noise floor calibration failure Felix Fietkau
2014-10-20 8:30 ` Sujith Manoharan
2014-10-18 17:02 ` [PATCH 06/10] ath9k_hw: do not run NF and periodic calibration at the same time Felix Fietkau
2014-10-20 8:41 ` Sujith Manoharan
2014-10-18 17:02 ` [PATCH 07/10] ath9k_hw: start initial NF calibration after PA calibration on <AR9003 Felix Fietkau
2014-10-20 8:45 ` Sujith Manoharan
2014-10-18 17:02 ` [PATCH 08/10] ath9k: add support for endian swap of eeprom from platform data Felix Fietkau
2014-10-18 17:02 ` [PATCH 09/10] ath9k: allow disabling bands via " Felix Fietkau
2014-10-18 17:02 ` [PATCH 10/10] ath9k: use a random MAC address if the EEPROM address is invalid Felix Fietkau
2014-10-20 7:57 ` [PATCH 01/10] ath9k_hw: make support for PC-OEM cards optional Sujith Manoharan
2014-10-20 8:53 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5444CF6C.8050208@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).