From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 7/7] ath10k: implement wmi-tlv backend
Date: Mon, 20 Oct 2014 14:36:21 -0700 [thread overview]
Message-ID: <54458055.50706@candelatech.com> (raw)
In-Reply-To: <1413809925-4352-8-git-send-email-michal.kazior@tieto.com>
On 10/20/2014 05:58 AM, Michal Kazior wrote:
> Latest firmware revision introduced a new WMI ABI
> called wmi-tlv. It is not a tlv strictly speaking
> but something that resembles it because it is
> ordered and may have duplicate id entries.
>
> This will be used by new hardware eventually.
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 00cff91..3fea38c 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -364,6 +364,9 @@ enum ath10k_fw_features {
> */
> ATH10K_FW_FEATURE_WMI_10_2 = 4,
>
> + /* Firmware uses WMI TLV */
> + ATH10K_FW_FEATURE_WMI_TLV = 5,
> +
> /* keep last */
> ATH10K_FW_FEATURE_COUNT,
> };
It sucks for me that I cannot get a feature-flag for my firmware upstream,
so my kernels and firmware keep loosing compatibility each time you
add a new flag.
I guess I will just have to pick a much larger value and just hope it
won't collide for a while.
But, if you are at liberty to change this, please skip 5 and 6,
and make yours be 7 (my kernel/firmware currently uses the two below):
/* Firmware from Candela Technologies, enables more VIFs, etc */
ATH10K_FW_FEATURE_WMI_10X_CT = 5,
/* Firmware from Candela Technologies with rx-software-crypt.
* Required for multiple stations connected to same AP when using
* encryption (ie, commercial version of CT firmware) */
ATH10K_FW_FEATURE_CT_RXSWCRYPT = 6,
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-10-20 21:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 12:58 [PATCH 0/7] ath10k: add support for new wmi-tlv backend Michal Kazior
2014-10-20 12:58 ` [PATCH 1/7] ath10k: fix wmi svc bitmap dbg print Michal Kazior
2014-10-20 12:58 ` [PATCH 2/7] ath10k: add sanity checks for service bmap parsing Michal Kazior
2014-10-20 12:58 ` [PATCH 3/7] ath10k: make wmi service bitmap non-debug Michal Kazior
2014-10-20 12:58 ` [PATCH 4/7] ath10k: implement intermediate event args Michal Kazior
2014-10-20 12:58 ` [PATCH 5/7] ath10k: introduce wmi ops Michal Kazior
2014-10-20 12:58 ` [PATCH 6/7] ath10k: make some wmi functions public Michal Kazior
2014-10-20 12:58 ` [PATCH 7/7] ath10k: implement wmi-tlv backend Michal Kazior
2014-10-20 13:32 ` Michal Kazior
2014-10-20 21:36 ` Ben Greear [this message]
2014-10-24 10:39 ` Michal Kazior
2014-10-28 11:34 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54458055.50706@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).