From: Larry Finger <Larry.Finger@lwfinger.net>
To: Karsten Wiese <fzuuzf@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] rtl8192cu: Call ieee80211_register_hw from rtl_usb_probe
Date: Wed, 22 Oct 2014 11:31:23 -0500 [thread overview]
Message-ID: <5447DBDB.3040706@lwfinger.net> (raw)
In-Reply-To: <1413985654-25070-3-git-send-email-fzuuzf@googlemail.com>
On 10/22/2014 08:47 AM, Karsten Wiese wrote:
> In a previous patch the call to ieee80211_register_hw was moved from the
> load firmware callback to the rtl_pci_probe only.
> rt8192cu also uses this callback. Currently it doesnt create a wlan%d device.
> Fill in the call to ieee80211_register_hw in rtl_usb_probe.
>
> Signed-off-by: Karsten Wiese <fzuuzf@googlemail.com>
> ---
> drivers/net/wireless/rtlwifi/usb.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Sorry that I missed this one.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
> index 10cf69c..46ee956 100644
> --- a/drivers/net/wireless/rtlwifi/usb.c
> +++ b/drivers/net/wireless/rtlwifi/usb.c
> @@ -1117,7 +1117,18 @@ int rtl_usb_probe(struct usb_interface *intf,
> }
> rtlpriv->cfg->ops->init_sw_leds(hw);
>
> + err = ieee80211_register_hw(hw);
> + if (err) {
> + RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> + "Can't register mac80211 hw.\n");
> + err = -ENODEV;
> + goto error_out;
> + }
> + rtlpriv->mac80211.mac80211_registered = 1;
> +
> + set_bit(RTL_STATUS_INTERFACE_START, &rtlpriv->status);
> return 0;
> +
> error_out:
> rtl_deinit_core(hw);
> _rtl_usb_io_handler_release(hw);
>
next prev parent reply other threads:[~2014-10-22 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 13:47 [PATCH 0/3] Fix rtl8192cu in 3.18-rc1 Karsten Wiese
2014-10-22 13:47 ` [PATCH 1/3] rtl8192cu: Fix for rtlwifi's bluetooth coexist functionality Karsten Wiese
2014-10-22 16:30 ` Larry Finger
2014-10-22 13:47 ` [PATCH 2/3] rtl8192cu: Call ieee80211_register_hw from rtl_usb_probe Karsten Wiese
2014-10-22 16:31 ` Larry Finger [this message]
2014-10-22 13:47 ` [PATCH 3/3] rtl8192cu: Prevent Ooops under rtl92c_set_fw_rsvdpagepkt Karsten Wiese
2014-10-22 16:35 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447DBDB.3040706@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=fzuuzf@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).