From: Felix Fietkau <nbd@openwrt.org>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
Date: Thu, 23 Oct 2014 12:57:15 +0200 [thread overview]
Message-ID: <5448DF0B.2090906@openwrt.org> (raw)
In-Reply-To: <87k33rqmwq.fsf@kamboji.qca.qualcomm.com>
On 2014-10-23 09:13, Kalle Valo wrote:
> Felix Fietkau <nbd@openwrt.org> writes:
>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>> index 4670930..bc440dc 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>
>> survey->channel = &sband->channels[idx];
>>
>> + if (ar->rx_channel == survey->channel)
>> + survey->filled |= SURVEY_INFO_IN_USE;
>> +
>
> Why? Does this fix a visible bug? What changes from user space point of
> view? I'm asking because I want to add something to the commit log.
When user space requests survey info, it is useful to know which of the
survey data refers to the channel that is currently actively being used.
One of the use cases is getting the current channel noise for status output.
Without this flag you would have to look up the channel separately and
then compare it against the frequency in the survey output in user space.
- Felix
next prev parent reply other threads:[~2014-10-23 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 16:46 [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey Felix Fietkau
2014-10-23 7:13 ` Kalle Valo
2014-10-23 10:57 ` Felix Fietkau [this message]
2014-10-23 13:31 ` Kalle Valo
2014-10-24 13:35 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5448DF0B.2090906@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).