[PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

[PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

[Felix Fietkau]

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
 drivers/net/wireless/ath/ath10k/mac.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 4670930..bc440dc 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
 
 	survey->channel = &sband->channels[idx];
 
+	if (ar->rx_channel == survey->channel)
+		survey->filled |= SURVEY_INFO_IN_USE;
+
 exit:
 	mutex_unlock(&ar->conf_mutex);
 	return ret;
-- 
2.0.4

Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

[Kalle Valo]

Felix Fietkau <nbd@openwrt.org> writes:

> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
>  drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 4670930..bc440dc 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>  
>  	survey->channel = &sband->channels[idx];
>  
> +	if (ar->rx_channel == survey->channel)
> +		survey->filled |= SURVEY_INFO_IN_USE;
> +

Why? Does this fix a visible bug? What changes from user space point of
view? I'm asking because I want to add something to the commit log.

-- 
Kalle Valo

Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

[Felix Fietkau]

On 2014-10-23 09:13, Kalle Valo wrote:
> Felix Fietkau <nbd@openwrt.org> writes:
> 
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> ---
>>  drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>> index 4670930..bc440dc 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>  
>>  	survey->channel = &sband->channels[idx];
>>  
>> +	if (ar->rx_channel == survey->channel)
>> +		survey->filled |= SURVEY_INFO_IN_USE;
>> +
> 
> Why? Does this fix a visible bug? What changes from user space point of
> view? I'm asking because I want to add something to the commit log.
When user space requests survey info, it is useful to know which of the
survey data refers to the channel that is currently actively being used.
One of the use cases is getting the current channel noise for status output.
Without this flag you would have to look up the channel separately and
then compare it against the frequency in the survey output in user space.

- Felix

Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

[Kalle Valo]

Felix Fietkau <nbd@openwrt.org> writes:

> On 2014-10-23 09:13, Kalle Valo wrote:
>> Felix Fietkau <nbd@openwrt.org> writes:
>> 
>>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>>> ---
>>>  drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>>> index 4670930..bc440dc 100644
>>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>>  
>>>  	survey->channel = &sband->channels[idx];
>>>  
>>> +	if (ar->rx_channel == survey->channel)
>>> +		survey->filled |= SURVEY_INFO_IN_USE;
>>> +
>> 
>> Why? Does this fix a visible bug? What changes from user space point of
>> view? I'm asking because I want to add something to the commit log.
>
> When user space requests survey info, it is useful to know which of the
> survey data refers to the channel that is currently actively being used.
> One of the use cases is getting the current channel noise for status output.
> Without this flag you would have to look up the channel separately and
> then compare it against the frequency in the survey output in user space.

Perfect, thanks. I added this to the commit log in ath-next-test:

commit f7528c6fca1b2ee1899069f1066012f47586a0c8
Author: Felix Fietkau <nbd@openwrt.org>
Date:   Wed Oct 22 18:46:02 2014 +0200

    ath10k: add SURVEY_INFO_IN_USE for current channel on survey
    
    When user space requests survey info, it is useful to know which of the survey
    data refers to the channel that is currently actively being used.  One of the
    use cases is getting the current channel noise for status output.  Without this
    flag you would have to look up the channel separately and then compare it
    against the frequency in the survey output in user space.
    
    Signed-off-by: Felix Fietkau <nbd@openwrt.org>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

-- 
Kalle Valo

Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

[Kalle Valo]

Felix Fietkau <nbd@openwrt.org> writes:

> Signed-off-by: Felix Fietkau <nbd@openwrt.org>

Thanks, applied.

-- 
Kalle Valo