From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:42640 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758132AbaJ3Tsh (ORCPT ); Thu, 30 Oct 2014 15:48:37 -0400 Message-ID: <54529613.2030102@broadcom.com> (sfid-20141030_204841_963435_EDF390B0) Date: Thu, 30 Oct 2014 20:48:35 +0100 From: Arend van Spriel MIME-Version: 1.0 To: Greg Kroah-Hartman CC: "John W. Linville" , , Subject: Re: [PATCH 0/3] debugfs: adding helper for single seq_file References: <1414498752-9746-1-git-send-email-arend@broadcom.com> <20141030191922.GA3768@tuxdriver.com> <20141030193914.GA28346@kroah.com> In-Reply-To: <20141030193914.GA28346@kroah.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10/30/14 20:39, Greg Kroah-Hartman wrote: > On Thu, Oct 30, 2014 at 03:19:22PM -0400, John W. Linville wrote: >> On Tue, Oct 28, 2014 at 01:19:09PM +0100, Arend van Spriel wrote: >>> The first patch was already posted earlier: >>> >>> Message-ID:<1413043315-22332-1-git-send-email-arend@broadcom.com> >>> >>> This series include changes in driver code to investigate potential >>> code savings. As example used the ath9k driver as it has a fair >>> amount of debugfs files. In this series it changes 7 debugfs entries >>> to use seq_file and the helper function. Below the output of the >>> size utility: >>> >>> text data bss dec hex filename >>> 115968 1225 28 117221 1c9e5 original/ath9k.o >>> 113224 1225 28 114477 1bf2d seq_file/ath9k.o >>> 111024 1225 28 112277 1b695 helper/ath9k.o >>> >>> This series is for 3.19 kernel and applies to the driver-core-next >>> branch of the driver-core repository. If needed the ath9k patches >>> may be dropped for now and I will resubmit them to wireless-next >>> once the debugfs patch has made it into linux-next. >>> >>> Arend van Spriel (3): >>> debugfs: add helper function to create device related seq_file >>> ath: use seq_file api for ath9k debugfs files >>> ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file >>> entries >> >> Greg, >> >> If you are happy with the debugfs change then feel free to merge the >> wireless patches along with it. > > Ok, will do, can I get your Ack for them? I saw a patch from Dan Carpenter on one of the functions I converted so if John has taken that one [1] it may give merge conflict in linux-next. Regards, Arend [1] http://mid.gmane.org/20141029154805.GC5290@mwanda > thanks, > > greg k-h