From: Larry Finger <Larry.Finger@lwfinger.net>
To: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Murilo Opsfelder Araujo <mopsfelder@gmail.com>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>,
Thadeu Cascardo <cascardo@cascardo.eti.br>,
troy_tan@realsil.com.cn
Subject: Re: [PATCH] rtlwifi: Add more checks for get_btc_status callback
Date: Wed, 05 Nov 2014 12:12:36 -0600 [thread overview]
Message-ID: <545A6894.7040506@lwfinger.net> (raw)
In-Reply-To: <1415178975.5402.66.camel@marge.simpson.net>
On 11/05/2014 03:16 AM, Mike Galbraith wrote:
> On Wed, 2014-10-29 at 23:30 -0500, Larry Finger wrote:
>> On 10/29/2014 06:28 PM, Murilo Opsfelder Araujo wrote:
>>> This is a complement of commit 08054200117a95afc14c3d2ed3a38bf4e345bf78
>>> "rtlwifi: Add check for get_btc_status callback".
>>>
>>> With this patch, next-20141029 at least does not panic with rtl8192se
>>> device.
>>>
>>
>> This patch is OK, but as noted it is not complete.
>>
>> I have patches to fix all the kernel panics for rtl8192se AND rtl8192ce. There
>> are missing parts, but I would prefer submitting mine, which would conflict with
>> this one. For that reason, NACK for this one, and please apply the set I am
>> submitting now.
>
> It's all in there now, but my RTL8191SEvB is still dead. Squabbling
> with it isn't going all that well either.
>
> As soon as 38506ece rtlwifi: rtl_pci: Start modification for new drivers
> is applied, explosions appear. Subsequently applying...
>
> 08054200 rtlwifi: Add check for get_btc_status callback
> c0386f15 rtlwifi: rtl8192ce: rtl8192de: rtl8192se: Fix handling for missing get_btc_status
> 50147969 rtlwifi: rtl8192se: Fix duplicate calls to ieee80211_register_hw()
> 30c5ccc6 rtlwifi: rtl8192se: Add missing section to read descriptor setting
> 75a916e1 rtlwifi: rtl8192se: Fix firmware loading
>
> ...fixes that mess up, but leaves the interface dead in the same manner
> as if nothing has been reverted. So it _seems_ the bustage lurks in
> 38506ece somewhere. Too bad it's non-dinky, and written in wifi-ese :)
Yes, I am aware that rtl8192se is failing, and now that I am back from vacation,
I am working on the problem. If you want to use the driver with kernel 3.18,
clone the repo at http://github.com/lwfinger/rtlwifi_new.git and build and
install either the master or kernel_version branches. Both work.
I am in the process of trying to find what the crucial difference is between
that repo and the kernel version.
Larry
next prev parent reply other threads:[~2014-11-05 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 23:28 [PATCH] rtlwifi: Add more checks for get_btc_status callback Murilo Opsfelder Araujo
2014-10-30 4:30 ` Larry Finger
2014-11-05 9:16 ` Mike Galbraith
2014-11-05 18:12 ` Larry Finger [this message]
2014-11-06 3:03 ` Mike Galbraith
2014-11-06 11:40 ` Murilo Opsfelder Araujo
2014-11-06 22:52 ` Murilo Opsfelder Araujo
2014-11-06 23:30 ` Larry Finger
2014-11-12 23:03 ` Murilo Opsfelder Araújo
2014-11-14 15:41 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A6894.7040506@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=cascardo@cascardo.eti.br \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mopsfelder@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=troy_tan@realsil.com.cn \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).