From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:17644 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbaKJU32 (ORCPT ); Mon, 10 Nov 2014 15:29:28 -0500 Message-ID: <54611FF5.40405@broadcom.com> (sfid-20141110_212944_091505_1482334E) Date: Mon, 10 Nov 2014 21:28:37 +0100 From: Arend van Spriel MIME-Version: 1.0 To: Jes Sorensen , Chris Ruffin CC: , , , Larry Finger , "Greg Kroah-Hartman" Subject: Re: [PATCH] staging: rtl8723au: change typecast to match type returned by htons() References: <1415650025-16403-1-git-send-email-cmruffin@gmail.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10-11-14 21:21, Jes Sorensen wrote: > Chris Ruffin writes: >> Using a u16 pointer typecast for a result from htons() results in the following warning from sparse: >> >> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: warning: incorrect type in assignment (different base types) >> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: expected unsigned short [unsigned] [short] [usertype] >> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: got restricted __be16 [usertype] >> >> This patch fixes the issue by using an endian-specific typecast >> that will always match the type returned by htons(). >> >> Signed-off-by: Chris Ruffin >> --- >> drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Looks fine to me > > Signed-off-by: Jes Sorensen > >> >> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c >> index a0f7e27..44ef55c 100644 >> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c >> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c >> @@ -1276,7 +1276,7 @@ s32 rtw_put_snap23a(u8 *data, u16 h_proto) >> snap->oui[0] = oui[0]; >> snap->oui[1] = oui[1]; >> snap->oui[2] = oui[2]; >> - *(u16 *)(data + SNAP_SIZE) = htons(h_proto); >> + *(__be16 *)(data + SNAP_SIZE) = htons(h_proto); Could (data + SNAP_SIZE) be on a unaligned address? Regards, Arend >> return SNAP_SIZE + sizeof(u16); >> } > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >