linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-wireless Mailing List <linux-wireless@vger.kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	"brcm80211-dev-list@broadcom.com"
	<brcm80211-dev-list@broadcom.com>
Subject: Re: brcmfmac not working on ECS LIVA
Date: Wed, 12 Nov 2014 11:40:57 +0100	[thread overview]
Message-ID: <54633939.6000400@broadcom.com> (raw)
In-Reply-To: <CAMP44s2V59VDx0s7q5Yr=KvGZNn8ptRJGHS4W8Ja=+ciKZaSzg@mail.gmail.com>

On 11-11-14 23:32, Felipe Contreras wrote:
> On Sun, Nov 9, 2014 at 4:46 AM, Arend van Spriel <arend@broadcom.com> wrote:
> 
>> Could you share the nvram obtained from EFI? Also please create a kernel log
>> with debug=0xd416.
> 
> There you go:
> http://people.freedesktop.org/~felipec/dmesg-brcm.txt
> 

It is using the sdhci-acpi driver for the sdio host controller. If I am
not mistaken that one does runtime-pm. This has caused issues with our
device. This is what happens:

1. driver sends control message and waits for firmware response.
 2. runtime pm kicks in and suspends host controller.
  3. host controller suspend disable sdio clock.
   4. host controller does not detect firmware interrupt for response.
    5. control message times out.

You can disable it through sysfs, but the patch below may do it.

Regards,
Arend

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
b/drivers/net/wire
index f754ffc..d231e65 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
@@ -27,6 +27,7 @@
 #include <linux/mmc/sdio_func.h>
 #include <linux/mmc/card.h>
 #include <linux/mmc/host.h>
+#include <linux/pm_runtime.h>
 #include <linux/platform_device.h>
 #include <linux/platform_data/brcmfmac-sdio.h>
 #include <linux/suspend.h>
@@ -976,6 +977,12 @@ static int brcmf_sdiod_probe(struct brcmf_sdio_dev
*sdiodev
                                           SG_MAX_SINGLE_ALLOC);
        sdiodev->max_segment_size = host->max_seg_size;

+       /*
+        * Several issues with the driver seem to occur when the SDIO host
+        * is using runtime-pm. Prevent host from doing runtime-pm here.
+        */
+       __pm_runtime_use_autosuspend(&host->class_dev, false);
+
        /* allocate scatter-gather table. sg support
         * will be disabled upon allocation failure.
         */


  reply	other threads:[~2014-11-12 10:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-08 20:39 brcmfmac not working on ECS LIVA Felipe Contreras
2014-11-09 10:46 ` Arend van Spriel
2014-11-10 20:48   ` Felipe Contreras
2014-11-11 11:08     ` Arend van Spriel
2014-11-11 18:32       ` Felipe Contreras
2014-11-11 18:35         ` Arend van Spriel
2014-11-11 18:49           ` Felipe Contreras
2014-11-11 19:10             ` Arend van Spriel
2014-11-11 19:13               ` Felipe Contreras
2014-11-11 22:32   ` Felipe Contreras
2014-11-12 10:40     ` Arend van Spriel [this message]
2014-11-12 15:23       ` Felipe Contreras
2014-11-13 10:47         ` Arend van Spriel
2014-11-14 17:03           ` Felipe Contreras
2014-11-14 19:30             ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54633939.6000400@broadcom.com \
    --to=arend@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=felipe.contreras@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).