* Re: [PATCH] mac80211: Send peering open frame again if beacon from listen state peer is received
[not found] <2EB4F5C65A3B8E4E92660930F4EF6B5B0619B9@JPYOKXMS113.jp.sony.com>
@ 2014-11-13 18:17 ` Thomas Pedersen
0 siblings, 0 replies; only message in thread
From: Thomas Pedersen @ 2014-11-13 18:17 UTC (permalink / raw)
To: Nishikawa, Kenzoh, devel, linux-wireless@vger.kernel.org
Hi Kenzoh,
Looks like your email is part HTML. Please submit using git-send-email.
Your patch looks ok, just a small comment below.
On 11/12/2014 08:27 PM, Nishikawa, Kenzoh via Devel wrote:
> net/mac80211/mesh_plink.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/net/mac80211/mesh_plink.c b/net/mac80211/mesh_plink.c
> index 32c7bd0..5ca4306 100644
> --- a/net/mac80211/mesh_plink.c
> +++ b/net/mac80211/mesh_plink.c
>
> @@ -524,6 +524,12 @@ void mesh_neighbour_update(struct ieee80211_sub_if_data *sdata,
> sdata->u.mesh.mshcfg.auto_open_plinks &&
> rssi_threshold_check(sta, sdata))
> changed = mesh_plink_open(sta);
> + else if (sta->plink_state == NL80211_PLINK_LISTEN &&
You should probably check for (sdata->u.mesh.security & IEEE80211_MESH_SEC_AUTHED)
as well like in mesh_sta_info_alloc().
> + sdata->u.mesh.user_mpm)
> + cfg80211_notify_new_peer_candidate(sdata->dev, hw_addr,
> + elems->ie_start,
> + elems->total_len,
> + GFP_KERNEL);
> ieee80211_mps_frame_release(sta, elems);
> out:
--
thomas
^ permalink raw reply [flat|nested] only message in thread