linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ranganath V N <vnranganath.20@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: wireless: util: Fix uninitialized header access in cfg80211_classify8021d
Date: Wed, 05 Nov 2025 16:17:31 +0100	[thread overview]
Message-ID: <546543a04e7e06a822bb0dccc10227e614a59cb6.camel@sipsolutions.net> (raw)
In-Reply-To: <20251103-fifth-v1-1-4a221737ddfe@gmail.com>

On Mon, 2025-11-03 at 00:02 +0530, Ranganath V N wrote:
> Fix an issue detected by  syzbot with KMSAN
> BUG: KMSAN: uninit-value in cfg80211_classify8021d+0x99d/0x12b0
> net/wireless/util.c:1027
> 
> The function accessed DSCP fields from IP and IPv6 headers without first
> verifying that sufficient header data was present in the skb. When a
> packet reaches this path, the header dereference could access
> uninitialized memory, as reported by KMSAN under fuzzing with syzkaller.
> 
> Add explicit pskb_may_pull() checks for both IPv4 and IPv6 headers to
> ensure that the required header data is available before extracting the
> DSCP field. This prevents uninitialized memory reads while preserving
> existing behavior for valid packets
> 
> This fix has been tested and validated by syzbot. This patch closes the
> bug reported at the following syzkaller link.Fixes the uninitialized
> header access.
> 
> Reported-by: syzbot+878ddc3962f792e9af59@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com./bug?extid=878ddc3962f792e9af59
> Tested-by: syzbot+878ddc3962f792e9af59@syzkaller.appspotmail.com
> Fixes: b156579b1404 ("Treat IPv6 diffserv the same as IPv4 for 802.11e")

Commit: 6132cdec43a5 ("net: wireless: util: Fix uninitialized header
access in cfg80211_classify8021d")
	Fixes tag: Fixes: b156579b1404 ("Treat IPv6 diffserv the same as IPv4 for 802.11e")
	Has these problem(s):
		- Subject does not match target commit subject
		  Just use
			git log -1 --format='Fixes: %h ("%s")'


Subject also needs to be adjusted.

johannes

      reply	other threads:[~2025-11-05 15:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-02 18:32 [PATCH] net: wireless: util: Fix uninitialized header access in cfg80211_classify8021d Ranganath V N
2025-11-05 15:17 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546543a04e7e06a822bb0dccc10227e614a59cb6.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vnranganath.20@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).