From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:34266 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756845AbaKTUCr (ORCPT ); Thu, 20 Nov 2014 15:02:47 -0500 Message-ID: <546E48DF.9020908@broadcom.com> (sfid-20141120_210249_745687_19FB173E) Date: Thu, 20 Nov 2014 21:02:39 +0100 From: Arend van Spriel MIME-Version: 1.0 To: Johannes Berg CC: "John W. Linville" , "linux-wireless@vger.kernel.org" Subject: Re: wireless-testing: unknown symbol 'wiphy_new' References: <546DEAE5.80904@broadcom.com> <1416489794.8557.0.camel@sipsolutions.net> In-Reply-To: <1416489794.8557.0.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/20/14 14:23, Johannes Berg wrote: > On Thu, 2014-11-20 at 14:21 +0100, Arend van Spriel wrote: >> Build a fresh kernel today, ie. 3.18-rc5-wl from wireless-testing and >> got the following message while building brcmfmac: >> >> LD [M] drivers/net/wireless/brcm80211/brcmfmac/brcmfmac.o >> Building modules, stage 2. >> MODPOST 2 modules >> WARNING: "wiphy_new" >> [drivers/net/wireless/brcm80211/brcmfmac/brcmfmac.ko] undefined! >> >> Did not sound encouraging to continue, but did anyway. Not surprisingly >> the insmod failed. Checking Module.symvers showed: >> >> [arend@lb-bun-235 ~/scm/brcm80211-next] >> $ grep wiphy_new Module.symvers >> 0xba575a46 wiphy_new_nm net/wireless/cfg80211 EXPORT_SYMBOL >> >> Rings a bell? We renamed the file wl_cfg80211.c that does wiphy_new() >> call to cfg80211.c. Merge issue? > > It's probably just a build issue? > > wiphy_new() is a static inline pointing to wiphy_new_nm() Indeed a build issue, but wiphy_new_nm() was recently introduced, right? Well, actually we were on 3.18-rc1 wireless-testing before I merged today. Thanks, Arend