From: Arend van Spriel <arend@broadcom.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-wireless@vger.kernel.org>, <ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH V2 0/3] debugfs: adding helper for single seq_file
Date: Fri, 21 Nov 2014 22:26:10 +0100 [thread overview]
Message-ID: <546FADF2.3030102@broadcom.com> (raw)
In-Reply-To: <1415529120-16314-1-git-send-email-arend@broadcom.com>
On 11/09/14 11:31, Arend van Spriel wrote:
> This series replaces the initial series posted:
>
> Message-ID:<1414498752-9746-1-git-send-email-arend@broadcom.com>
>
> This series include changes in driver code to investigate potential
> code savings. As example used the ath9k driver as it has a fair
> amount of debugfs files. In this series it changes 7 debugfs entries
> to use seq_file and the helper function. Below the output of the
> size utility:
>
> text data bss dec hex filename
> 115968 1225 28 117221 1c9e5 original/ath9k.o
> 113224 1225 28 114477 1bf2d seq_file/ath9k.o
> 111024 1225 28 112277 1b695 helper/ath9k.o
>
> This series is for 3.19 kernel and applies to the driver-core-next
> branch of the driver-core repository.
>
> The second patch has a number of CamelCase checks, but those were
> already present in code. So fixing that would be a separate effort.
Hi Greg,
These patches did not show up in driver-core repo so did you miss them.
If I need to rebase again, let me know.
Regards,
Arend
> Changelog:
> ----------
> V2:
> - fixed whitespace failures.
> - use seq_puts where applicable.
> - rebased on driver-core-next branch.
>
> Arend van Spriel (3):
> debugfs: add helper function to create device related seq_file
> ath: use seq_file api for ath9k debugfs files
> ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file
> entries
>
> drivers/net/wireless/ath/ath9k/ahb.c | 1 +
> drivers/net/wireless/ath/ath9k/debug.c | 459 +++++++++++----------------------
> drivers/net/wireless/ath/ath9k/debug.h | 11 +-
> drivers/net/wireless/ath/ath9k/pci.c | 1 +
> fs/debugfs/file.c | 54 ++++
> include/linux/debugfs.h | 16 +-
> 6 files changed, 226 insertions(+), 316 deletions(-)
>
prev parent reply other threads:[~2014-11-21 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 10:31 [PATCH V2 0/3] debugfs: adding helper for single seq_file Arend van Spriel
2014-11-09 10:31 ` [PATCH V2 1/3] debugfs: add helper function to create device related seq_file Arend van Spriel
2014-11-09 10:31 ` [PATCH V2 2/3] ath: use seq_file api for ath9k debugfs files Arend van Spriel
2014-11-09 10:32 ` [PATCH V2 3/3] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries Arend van Spriel
2014-11-21 21:26 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546FADF2.3030102@broadcom.com \
--to=arend@broadcom.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).