From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:17925 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194AbaKUV0M (ORCPT ); Fri, 21 Nov 2014 16:26:12 -0500 Message-ID: <546FADF2.3030102@broadcom.com> (sfid-20141121_222617_458788_11248E8F) Date: Fri, 21 Nov 2014 22:26:10 +0100 From: Arend van Spriel MIME-Version: 1.0 To: Arend van Spriel CC: Greg Kroah-Hartman , , Subject: Re: [PATCH V2 0/3] debugfs: adding helper for single seq_file References: <1415529120-16314-1-git-send-email-arend@broadcom.com> In-Reply-To: <1415529120-16314-1-git-send-email-arend@broadcom.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/09/14 11:31, Arend van Spriel wrote: > This series replaces the initial series posted: > > Message-ID:<1414498752-9746-1-git-send-email-arend@broadcom.com> > > This series include changes in driver code to investigate potential > code savings. As example used the ath9k driver as it has a fair > amount of debugfs files. In this series it changes 7 debugfs entries > to use seq_file and the helper function. Below the output of the > size utility: > > text data bss dec hex filename > 115968 1225 28 117221 1c9e5 original/ath9k.o > 113224 1225 28 114477 1bf2d seq_file/ath9k.o > 111024 1225 28 112277 1b695 helper/ath9k.o > > This series is for 3.19 kernel and applies to the driver-core-next > branch of the driver-core repository. > > The second patch has a number of CamelCase checks, but those were > already present in code. So fixing that would be a separate effort. Hi Greg, These patches did not show up in driver-core repo so did you miss them. If I need to rebase again, let me know. Regards, Arend > Changelog: > ---------- > V2: > - fixed whitespace failures. > - use seq_puts where applicable. > - rebased on driver-core-next branch. > > Arend van Spriel (3): > debugfs: add helper function to create device related seq_file > ath: use seq_file api for ath9k debugfs files > ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file > entries > > drivers/net/wireless/ath/ath9k/ahb.c | 1 + > drivers/net/wireless/ath/ath9k/debug.c | 459 +++++++++++---------------------- > drivers/net/wireless/ath/ath9k/debug.h | 11 +- > drivers/net/wireless/ath/ath9k/pci.c | 1 + > fs/debugfs/file.c | 54 ++++ > include/linux/debugfs.h | 16 +- > 6 files changed, 226 insertions(+), 316 deletions(-) >