* [PATCH] ath10k: unregister and remove frag_threshold callback
@ 2014-12-05 17:16 Peter Oh
2014-12-06 3:59 ` Ben Greear
2014-12-16 7:14 ` Kalle Valo
0 siblings, 2 replies; 6+ messages in thread
From: Peter Oh @ 2014-12-05 17:16 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless
Setting fragmentation threshold has not been supported by
any of firmware versions, hence unregister the callback and
remove the function.
Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 24 ------------------------
1 file changed, 24 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index c400567..604a4bc 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3989,29 +3989,6 @@ static int ath10k_set_rts_threshold(struct ieee80211_hw *hw, u32 value)
return ret;
}
-static int ath10k_set_frag_threshold(struct ieee80211_hw *hw, u32 value)
-{
- struct ath10k *ar = hw->priv;
- struct ath10k_vif *arvif;
- int ret = 0;
-
- mutex_lock(&ar->conf_mutex);
- list_for_each_entry(arvif, &ar->arvifs, list) {
- ath10k_dbg(ar, ATH10K_DBG_MAC, "mac vdev %d fragmentation threshold %d\n",
- arvif->vdev_id, value);
-
- ret = ath10k_mac_set_frag(arvif, value);
- if (ret) {
- ath10k_warn(ar, "failed to set fragmentation threshold for vdev %d: %d\n",
- arvif->vdev_id, ret);
- break;
- }
- }
- mutex_unlock(&ar->conf_mutex);
-
- return ret;
-}
-
static void ath10k_flush(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
u32 queues, bool drop)
{
@@ -4655,7 +4632,6 @@ static const struct ieee80211_ops ath10k_ops = {
.remain_on_channel = ath10k_remain_on_channel,
.cancel_remain_on_channel = ath10k_cancel_remain_on_channel,
.set_rts_threshold = ath10k_set_rts_threshold,
- .set_frag_threshold = ath10k_set_frag_threshold,
.flush = ath10k_flush,
.tx_last_beacon = ath10k_tx_last_beacon,
.set_antenna = ath10k_set_antenna,
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ath10k: unregister and remove frag_threshold callback
2014-12-05 17:16 [PATCH] ath10k: unregister and remove frag_threshold callback Peter Oh
@ 2014-12-06 3:59 ` Ben Greear
2014-12-10 18:33 ` poh
2014-12-16 7:14 ` Kalle Valo
1 sibling, 1 reply; 6+ messages in thread
From: Ben Greear @ 2014-12-06 3:59 UTC (permalink / raw)
To: Peter Oh, ath10k; +Cc: linux-wireless
On 12/05/2014 09:16 AM, Peter Oh wrote:
> Setting fragmentation threshold has not been supported by
> any of firmware versions, hence unregister the callback and
> remove the function.
How hard is it to just fix the firmware instead?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: unregister and remove frag_threshold callback
2014-12-06 3:59 ` Ben Greear
@ 2014-12-10 18:33 ` poh
2014-12-10 19:03 ` Ben Greear
0 siblings, 1 reply; 6+ messages in thread
From: poh @ 2014-12-10 18:33 UTC (permalink / raw)
To: Ben Greear, ath10k; +Cc: linux-wireless
On 12/05/2014 07:59 PM, Ben Greear wrote:
>
>
> On 12/05/2014 09:16 AM, Peter Oh wrote:
>> Setting fragmentation threshold has not been supported by
>> any of firmware versions, hence unregister the callback and
>> remove the function.
>
> How hard is it to just fix the firmware instead?
It's due to hardware limitation such as lack of buffers/RAM size
limitation, hence it's very hard from sw perspective.
>
> Thanks,
> Ben
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: unregister and remove frag_threshold callback
2014-12-10 18:33 ` poh
@ 2014-12-10 19:03 ` Ben Greear
2014-12-10 19:55 ` Peter Oh
0 siblings, 1 reply; 6+ messages in thread
From: Ben Greear @ 2014-12-10 19:03 UTC (permalink / raw)
To: poh; +Cc: ath10k, linux-wireless
On 12/10/2014 10:33 AM, poh wrote:
>
> On 12/05/2014 07:59 PM, Ben Greear wrote:
>>
>>
>> On 12/05/2014 09:16 AM, Peter Oh wrote:
>>> Setting fragmentation threshold has not been supported by
>>> any of firmware versions, hence unregister the callback and
>>> remove the function.
>>
>> How hard is it to just fix the firmware instead?
> It's due to hardware limitation such as lack of buffers/RAM size limitation, hence it's very hard from sw perspective.
Out of curiosity, how much more RAM do you need? I was able to squeeze somewhere around 80k out of the firmware
in my quest to support 64 station vdevs....
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: unregister and remove frag_threshold callback
2014-12-10 19:03 ` Ben Greear
@ 2014-12-10 19:55 ` Peter Oh
0 siblings, 0 replies; 6+ messages in thread
From: Peter Oh @ 2014-12-10 19:55 UTC (permalink / raw)
To: Ben Greear; +Cc: ath10k, linux-wireless
On 12/10/2014 11:03 AM, Ben Greear wrote:
> On 12/10/2014 10:33 AM, poh wrote:
>> On 12/05/2014 07:59 PM, Ben Greear wrote:
>>>
>>> On 12/05/2014 09:16 AM, Peter Oh wrote:
>>>> Setting fragmentation threshold has not been supported by
>>>> any of firmware versions, hence unregister the callback and
>>>> remove the function.
>>> How hard is it to just fix the firmware instead?
>> It's due to hardware limitation such as lack of buffers/RAM size limitation, hence it's very hard from sw perspective.
> Out of curiosity, how much more RAM do you need? I was able to squeeze somewhere around 80k out of the firmware
> in my quest to support 64 station vdevs....
I don't have exact number of memory since the answer is from our
firmware team.
I assume it's not coming in near future to firmware.
> Thanks,
> Ben
>
Thanks,
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: unregister and remove frag_threshold callback
2014-12-05 17:16 [PATCH] ath10k: unregister and remove frag_threshold callback Peter Oh
2014-12-06 3:59 ` Ben Greear
@ 2014-12-16 7:14 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2014-12-16 7:14 UTC (permalink / raw)
To: Peter Oh; +Cc: ath10k, linux-wireless
Peter Oh <poh@qca.qualcomm.com> writes:
> Setting fragmentation threshold has not been supported by
> any of firmware versions, hence unregister the callback and
> remove the function.
>
> Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
Thanks, applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-16 7:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 17:16 [PATCH] ath10k: unregister and remove frag_threshold callback Peter Oh
2014-12-06 3:59 ` Ben Greear
2014-12-10 18:33 ` poh
2014-12-10 19:03 ` Ben Greear
2014-12-10 19:55 ` Peter Oh
2014-12-16 7:14 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).