From: Larry Finger <Larry.Finger@lwfinger.net>
To: Krzysztof Konopko <kris@konagma.com>,
Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: Fix sparse warnings
Date: Fri, 12 Dec 2014 21:18:24 -0600 [thread overview]
Message-ID: <548BB000.8020202@lwfinger.net> (raw)
In-Reply-To: <548B7120.8010008@konagma.com>
On 12/12/2014 04:50 PM, Krzysztof Konopko wrote:
> On 12/12/14 18:35, Larry Finger wrote:
>> On 12/12/2014 05:35 AM, Krzysztof Konopko wrote:
>>> On 12/12/14 00:53, Larry Finger wrote:
>>>> In particular, did you test on big-endian hardware after you
>>>> made this change?
>>>
>>> Nope. I don't have any big-endian hardware. I don't even have the
>>> wireless card TBH. But I'm happy to try to get one. Is Rtl8723AE the
>>> right model?
>>
>> No. The device numbers that end in E are PCIe and use a mac80211-based
>> driver. As none of my BE hardware has PCIe, I cannot test those drivers
>> on other than LE hardware. I do not have the hardware either for the
>> RTL8723AU. For that reason, I am careful when modifying the driver - I
>> let Jes do that.
>>
>
> Silly me. 'U' stands for USB here. But can't find this device on any
> auction. It's included in some ultrabooks but can't afford that for the
> sake of fixing some sparse warnings :)
There are no stand-alone USB devices that I have found for either RTL8723AU or
RTL8723BU. The closest are modules CM-8723U and CM-8723BU by CC&C
(http://www.ccandc.com.tw/) with RTL8723AU and RTL8723BU, respectively. The
former is obsolete and no longer on the web site. These modules have D+ and D-
connectors for USB, but they take 3.3 V, not 5. As a result, one would need some
sort of voltage regulator circuit. That would not be complicated as it would
consist of a TI LM2937-3.3 and a couple of capacitors. I wrote to them to see if
I could get samples, but no response yet.
>> To be able to fix the kernel driver for RTL8188EU on PPC, I need to sort
>> out these endian problems. Once I do, I will port them to the other
>> drivers.
>>
>
> Isn't `sparse` useful here? :)
Yes, but the git repo works, and the kernel version does not, even though both
do not have any Sparse warhings.
Larry
next prev parent reply other threads:[~2014-12-13 3:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 22:23 [PATCH] staging: rtl8723au: Fix sparse warnings Krzysztof Konopko
2014-12-11 23:53 ` Larry Finger
2014-12-12 11:35 ` Krzysztof Konopko
2014-12-12 13:24 ` Johannes Berg
2014-12-12 17:10 ` Jes Sorensen
2014-12-12 17:35 ` Larry Finger
2014-12-12 18:52 ` Jes Sorensen
2014-12-12 22:55 ` Krzysztof Konopko
2014-12-15 15:36 ` Jes Sorensen
2014-12-12 22:50 ` Krzysztof Konopko
2014-12-13 3:18 ` Larry Finger [this message]
2014-12-12 12:52 ` Dan Carpenter
2014-12-12 16:43 ` Larry Finger
2014-12-12 22:30 ` Krzysztof Konopko
2014-12-12 17:12 ` Jes Sorensen
2014-12-12 22:34 ` Krzysztof Konopko
2014-12-12 22:58 ` Krzysztof Konopko
2014-12-13 6:43 ` Joe Perches
2014-12-15 15:02 ` Krzysztof Konopko
2014-12-15 15:46 ` Jes Sorensen
2014-12-15 15:39 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548BB000.8020202@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Jes.Sorensen@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kris@konagma.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).