From: Malcolm Priestley <tvboxspy@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: vt6655: set_channel replace parameter with ieee80211_channel
Date: Wed, 17 Dec 2014 23:16:44 +0000 [thread overview]
Message-ID: <54920EDC.4090007@gmail.com> (raw)
In-Reply-To: <1417731167-3231-1-git-send-email-tvboxspy@gmail.com>
On 04/12/14 22:12, Malcolm Priestley wrote:
> replacing uConnectionChannel for hw_value as set in vnt_init_bands.
>
> This allows other signaling of ieee80211_channel to move deeper into
> driver.
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
Hi greg
Can you drop this patch series altogether.
I will repost these later after some needed bug fixes for 3.19
Malcolm
> drivers/staging/vt6655/channel.c | 12 ++++++------
> drivers/staging/vt6655/channel.h | 2 +-
> drivers/staging/vt6655/device_main.c | 2 +-
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
> index c8f739d..6514869 100644
> --- a/drivers/staging/vt6655/channel.c
> +++ b/drivers/staging/vt6655/channel.c
> @@ -174,12 +174,12 @@ void vnt_init_bands(struct vnt_private *priv)
> * Return Value: true if succeeded; false if failed.
> *
> */
> -bool set_channel(void *pDeviceHandler, unsigned int uConnectionChannel)
> +bool set_channel(void *pDeviceHandler, struct ieee80211_channel *ch)
> {
> struct vnt_private *pDevice = pDeviceHandler;
> bool bResult = true;
>
> - if (pDevice->byCurrentCh == uConnectionChannel)
> + if (pDevice->byCurrentCh == ch->hw_value)
> return bResult;
>
> /* clear NAV */
> @@ -189,15 +189,15 @@ bool set_channel(void *pDeviceHandler, unsigned int uConnectionChannel)
>
> if (pDevice->byRFType == RF_AIROHA7230)
> RFbAL7230SelectChannelPostProcess(pDevice, pDevice->byCurrentCh,
> - (unsigned char)uConnectionChannel);
> + (unsigned char)ch->hw_value);
>
> - pDevice->byCurrentCh = (unsigned char)uConnectionChannel;
> + pDevice->byCurrentCh = (unsigned char)ch->hw_value;
> bResult &= RFbSelectChannel(pDevice, pDevice->byRFType,
> - (unsigned char)uConnectionChannel);
> + (unsigned char)ch->hw_value);
>
> /* Init Synthesizer Table */
> if (pDevice->bEnablePSMode)
> - RFvWriteWakeProgSyn(pDevice, pDevice->byRFType, uConnectionChannel);
> + RFvWriteWakeProgSyn(pDevice, pDevice->byRFType, ch->hw_value);
>
> BBvSoftwareReset(pDevice);
>
> diff --git a/drivers/staging/vt6655/channel.h b/drivers/staging/vt6655/channel.h
> index 4f4264e..e2be6fc 100644
> --- a/drivers/staging/vt6655/channel.h
> +++ b/drivers/staging/vt6655/channel.h
> @@ -27,6 +27,6 @@
>
> void vnt_init_bands(struct vnt_private *);
>
> -bool set_channel(void *pDeviceHandler, unsigned int uConnectionChannel);
> +bool set_channel(void *pDeviceHandler, struct ieee80211_channel *);
>
> #endif /* _CHANNEL_H_ */
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 83e4162..b50c4f2 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1415,7 +1415,7 @@ static int vnt_config(struct ieee80211_hw *hw, u32 changed)
>
> if ((changed & IEEE80211_CONF_CHANGE_CHANNEL) ||
> (conf->flags & IEEE80211_CONF_OFFCHANNEL)) {
> - set_channel(priv, conf->chandef.chan->hw_value);
> + set_channel(priv, conf->chandef.chan);
>
> if (conf->chandef.chan->band == IEEE80211_BAND_5GHZ)
> bb_type = BB_TYPE_11A;
>
next prev parent reply other threads:[~2014-12-17 23:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 22:12 [PATCH 1/6] staging: vt6655: set_channel replace parameter with ieee80211_channel Malcolm Priestley
2014-12-04 22:12 ` [PATCH 2/6] staging: vt6655: common variable size channel numbers to ieee80211_channel->hw_value Malcolm Priestley
2014-12-04 22:12 ` [PATCH 3/6] staging: vt6655: remove antenna diversity functions Malcolm Priestley
2014-12-04 22:12 ` [PATCH 4/6] staging: vt6655: device_init_registers alway set initial antenna mode Malcolm Priestley
2014-12-04 22:12 ` [PATCH 5/6] staging: vt6655: Fix RFbSetPower() error: buffer overflow 'priv->abyCCKPwrTbl' 15 <= 56 Malcolm Priestley
2014-12-04 22:12 ` [PATCH 6/6] staging: vt6655: RFbSetPower remove unused variable byPwrdBm Malcolm Priestley
2014-12-17 23:16 ` Malcolm Priestley [this message]
2015-01-13 3:32 ` [PATCH 1/6] staging: vt6655: set_channel replace parameter with ieee80211_channel Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-01-19 18:24 Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54920EDC.4090007@gmail.com \
--to=tvboxspy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).