From: Arend van Spriel <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Rob Herring <rob.herring@linaro.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH 03/10] brcmfmac: Add support for bcm43340/1 wireless chipsets
Date: Mon, 22 Dec 2014 10:05:36 +0100 [thread overview]
Message-ID: <5497DEE0.1040007@broadcom.com> (raw)
In-Reply-To: <CACna6rxjKUeDVGXGB5UzgOw1WyQKE+LYmtxJvTLW+H1fC7-13Q@mail.gmail.com>
On 12/21/14 21:14, Rafał Miłecki wrote:
> On 21 December 2014 at 20:56, Arend van Spriel<arend@broadcom.com> wrote:
>> On 12/21/14 18:50, Marcel Holtmann wrote:
>>>
>>> Hi Arend,
>>>
>>>> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
>>>> index 0f01fe0..61f8318 100644
>>>> --- a/include/linux/mmc/sdio_ids.h
>>>> +++ b/include/linux/mmc/sdio_ids.h
>>>> @@ -29,6 +29,8 @@
>>>> #define SDIO_DEVICE_ID_BROADCOM_4329 0x4329
>>>> #define SDIO_DEVICE_ID_BROADCOM_4330 0x4330
>>>> #define SDIO_DEVICE_ID_BROADCOM_4334 0x4334
>>>> +#define SDIO_DEVICE_ID_BROADCOM_43340 43340
>>>> +#define SDIO_DEVICE_ID_BROADCOM_43341 43341
>>>
>>>
>>> the general preference is to have these values in hex. I get the fact that
>>> they map the marketing number, but that could be just stated in a comment
>>> after the hex number.
>>
>> Will change that.
>
> I vote for keeping user-friendly numbers as comments :)
I don't see added value as the define id ends with the marketing number.
Regards,
Arend
next prev parent reply other threads:[~2014-12-22 9:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 11:43 [PATCH 00/10] brcmfmac: new device support and more Arend van Spriel
2014-12-21 11:43 ` [PATCH 01/10] brcmfmac: Fix incorrect casting of 64 bit physical address Arend van Spriel
2014-12-21 17:24 ` Joe Perches
2014-12-21 11:43 ` [PATCH 02/10] brcmfmac: Fix possible dereference of NULL pointer Arend van Spriel
2014-12-23 17:07 ` Arend van Spriel
2014-12-21 11:43 ` [PATCH 03/10] brcmfmac: Add support for bcm43340/1 wireless chipsets Arend van Spriel
2014-12-21 17:50 ` Marcel Holtmann
2014-12-21 19:56 ` Arend van Spriel
2014-12-21 20:14 ` Rafał Miłecki
2014-12-22 9:05 ` Arend van Spriel [this message]
2014-12-22 9:33 ` Rafał Miłecki
2014-12-21 11:43 ` [PATCH 04/10] brcmfmac: get rid of duplicate SDIO device identifiers Arend van Spriel
2015-01-06 18:35 ` Kalle Valo
2014-12-21 11:43 ` [PATCH 05/10] brcmfmac: remove unused/duplicate defines in chip.c Arend van Spriel
2014-12-21 11:43 ` [PATCH 06/10] brcmfmac: Fix WEP configuration for AP mode Arend van Spriel
2014-12-21 11:43 ` [PATCH 07/10] brcmfmac: Change error log in standard log for rxbufpost Arend van Spriel
2014-12-21 11:43 ` [PATCH 08/10] brcmfmac: follow user-space regulatory domain selection Arend van Spriel
2014-12-21 11:43 ` [PATCH 09/10] brcmfmac: signal completion of 802.1x Arend van Spriel
2014-12-21 11:43 ` [PATCH 10/10] brcmfmac: enable 802.11d support in firmware Arend van Spriel
2015-01-06 18:36 ` [PATCH 00/10] brcmfmac: new device support and more Kalle Valo
2015-01-06 19:07 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5497DEE0.1040007@broadcom.com \
--to=arend@broadcom.com \
--cc=john.stultz@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rob.herring@linaro.org \
--cc=sameo@linux.intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).