From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:23354 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbaLWPkh (ORCPT ); Tue, 23 Dec 2014 10:40:37 -0500 Message-ID: <54998CE7.7030909@broadcom.com> (sfid-20141223_164040_955315_D7C3A837) Date: Tue, 23 Dec 2014 16:40:23 +0100 From: Arend van Spriel MIME-Version: 1.0 To: Johannes Berg CC: Avinash Patil , , , , Subject: Re: [PATCH] cfg80211: check for carrier state only when offchanel CAC supported References: <1419365159-6577-1-git-send-email-patila@marvell.com> <1419346405.6091.6.camel@sipsolutions.net> <54998B8E.3020002@broadcom.com> <1419349104.6091.8.camel@sipsolutions.net> In-Reply-To: <1419349104.6091.8.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/23/14 16:38, Johannes Berg wrote: > On Tue, 2014-12-23 at 16:34 +0100, Arend van Spriel wrote: >> On 12/23/14 15:53, Johannes Berg wrote: >>> On Wed, 2014-12-24 at 01:35 +0530, Avinash Patil wrote: >>>> Checking for carrier state during start_radar_detection is needed >>>> only for devices which support offchannel CAC. >>>> This patch adds one more condition while checking for carrier state >>>> to see if offchanel CAC is supported, else we need not check carrier >>>> state. >>>> >>>> Signed-off-by: Avinash Patil >>>> --- >>>> include/net/cfg80211.h | 2 ++ >>>> net/wireless/nl80211.c | 3 ++- >>>> 2 files changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h >>>> index 4ebb816..1b80302 100644 >>>> --- a/include/net/cfg80211.h >>>> +++ b/include/net/cfg80211.h >>>> @@ -2740,6 +2740,7 @@ struct cfg80211_ops { >>>> * @WIPHY_FLAG_SUPPORTS_5_10_MHZ: Device supports 5 MHz and 10 MHz channels. >>>> * @WIPHY_FLAG_HAS_CHANNEL_SWITCH: Device supports channel switch in >>>> * beaconing mode (AP, IBSS, Mesh, ...). >>>> + * @WIPHY_FLAG_OFFCHAN_CAC: Device supports offchannel CAC. >>> >>> I think this should be an nl80211 feature flag, so that userspace can >>> also know whether or not this is supported. >>> >>> However, we've run out of nl80211 feature flags. Arend is working on >>> adding more, see here: >>> http://mid.gmane.org/1418935344-22159-1-git-send-email-arend@broadcom.com >>> (ignore the 4-way-HS offload bit he's defining) >>> >>> I'm not sure how to proceed here - in a sense your feature flag is far >>> less controversial and work-intensive than Arend's (who needs a lot more >>> than just that patch) so I guess you could pick up his patch, but I >>> expect him to also have fixed already. He's probably also on vacation >>> for about the same time though... >> >> Not on vacation just yet. I indeed reworked the patch, but I was waiting >> for wpa_supplicant patches so I can verify it works with brcmfmac. I can >> submit the reworked feature flag patch with empty enum if that would work. > > Maybe if you were to do that Avinash could resubmit it again with the > feature flag they need. Fine by me. Will come out shortly. Gr. AvS