linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Gautam Kumar Shukla <gautams@broadcom.com>,
	Avinash Patil <patila@marvell.com>
Subject: Re: [PATCH] cfg80211: add extensible feature flag attribute
Date: Tue, 23 Dec 2014 17:05:20 +0100	[thread overview]
Message-ID: <549992C0.4080708@broadcom.com> (raw)
In-Reply-To: <1419350316.6091.9.camel@sipsolutions.net>

On 12/23/14 16:58, Johannes Berg wrote:
> On Tue, 2014-12-23 at 16:55 +0100, Arend van Spriel wrote:
>> From: Gautam Kumar Shukla<gautams@broadcom.com>
>>
>> With the wiphy::features flag being used up this patch adds a
>> new field wiphy::ext_features. Considering extensibility this
>> new field is declared as a byte array. This extensible flag is
>> exposed to user-space by NL80211_ATTR_EXT_FEATURES.
>
> Ah, I guess this will compile without even any flags defined, so
> Avinash, you can just build on top of this and define the first flag,
> and for the sake of attribution I'll apply it as two separate patches.

If Avinash keeps my signed-off-by and add note of what he changed below 
that I feel sufficiently attributed. Either way is fine by me.

It compiles, but I guess nla_put() will fail for u8[0+8-1/8] field.

Gr. AvS

> Thanks Arend.
>
> johannes
>


  reply	other threads:[~2014-12-23 16:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23 15:55 [PATCH] cfg80211: add extensible feature flag attribute Arend van Spriel
2014-12-23 15:58 ` Johannes Berg
2014-12-23 16:05   ` Arend van Spriel [this message]
2014-12-23 16:07     ` Johannes Berg
2014-12-23 19:05       ` Arend van Spriel
2015-01-06 10:35 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549992C0.4080708@broadcom.com \
    --to=arend@broadcom.com \
    --cc=gautams@broadcom.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=patila@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).