From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:51801 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbaLWRdd (ORCPT ); Tue, 23 Dec 2014 12:33:33 -0500 Message-ID: <5499A769.2000605@broadcom.com> (sfid-20141223_183350_077561_CB035C79) Date: Tue, 23 Dec 2014 18:33:29 +0100 From: Arend van Spriel MIME-Version: 1.0 To: Kalle Valo CC: Mika Westerberg , , Brett Rudley , Hante Meuleman , "John W. Linville" , Christophe Prigent , Subject: Re: [PATCH] brcmfmac: Do not crash if platform data is not populated References: <1419346112-173303-1-git-send-email-mika.westerberg@linux.intel.com> <54998C31.9090500@broadcom.com> <20141223154738.GM1314@lahna.fi.intel.com> <54999161.504@broadcom.com> <877fxie1x8.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <877fxie1x8.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/23/14 18:00, Kalle Valo wrote: > Arend van Spriel writes: > >> On 12/23/14 16:47, Mika Westerberg wrote: >>> On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote: >>>> On 12/23/14 15:48, Mika Westerberg wrote: >>>>> The driver looks for pdata->oob_irq_supported to find out if wowl can be >>>>> supported. However, not all platforms populate pdata in which case we crash >>>>> the kernel because of NULL pointer dereference. >>>> >>>> Thanks, Mika >>>> >>>> However, this was already reported by Dan Carpenter and I submitted a patch >>>> for that a couple of days ago: "[PATCH 02/10] brcmfmac: Fix possible >>>> dereference of NULL pointer." [1]. >>>> >>>> Regards, >>>> Arend >>>> >>>> [1] >>>> http://mid.gmane.org/1419162233-19492-3-git-send-email-arend@broadcom.com >>> >>> Oh, good. I didn't notice that one. >>> >>> Thanks for fixing it :) >>> >>> BTW, that patch seems to miss brcmf_ops_sdio_resume(), perhaps it is >>> fixed in another patch? >> >> Aargh, a nice "BTW" this is as there is no other patch for the resume >> code. Maybe I should ask Kalle to apply your patch instead of ours. If >> it did not already got applied. > > I have been waiting for net-next to open so I haven't applied any -next > patches yet. So if you want I can take Mika's patch as well. Just send a > reply to your patch I should drop. > > And should this patch go to 3.19? Yeah, the issue was introduced in 3.19 so that makes sense. Regards, Arend