linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Christian Lamparter <chunkeey@googlemail.com>,
	Christopher Chavez <chrischavez@gmx.us>
Cc: linux-wireless@vger.kernel.org
Subject: Re: p54usb kernel panic on recent mainline kernels
Date: Fri, 26 Dec 2014 13:05:43 -0600	[thread overview]
Message-ID: <549DB187.3090003@lwfinger.net> (raw)
In-Reply-To: <2868661.A1AiatZ287@debian64>

On 12/26/2014 08:35 AM, Christian Lamparter wrote:
> On Friday, December 26, 2014 04:23:21 AM Christopher Chavez wrote:
>> Larry Finger <Larry.Finger@...> writes:
>>> In any case, file a bug report at bugzilla.kernel.org, mark it as a regression,
>>> and post the bug number here. If you are able to finish the bisection, that
>>> would be helpful.
>>
>> Reported.
>> https://bugzilla.kernel.org/show_bug.cgi?id=90331
>
> According to what Larry wrote, this bug should disappear, if
> the hw crypto offloading is disabled.
>
> Christopher, can you please load the p54common kernel module
> with the module parameter "nohwcrypt=1" and report back?

Christian,

I can confirm that the skb panic goes away if hardware encryption is disabled.

My bisection led to a branch commit d17ec4d as the "bad" commit. Rather than 
finding out where the bisection went bad, I added code to check skb->tail, 
skb->end, and the length to be added. At the time of the call that panics, there 
are 6 bytes between tail and end with 8 bytes needed.

I will be looking for the place where the driver calculates how large the skb 
should be.

Larry


  reply	other threads:[~2014-12-26 19:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-25  4:39 p54usb kernel panic on recent mainline kernels Christopher Chavez
2014-12-25 22:27 ` Christian Lamparter
2014-12-26  2:41 ` Larry Finger
2014-12-26  4:23   ` Christopher Chavez
2014-12-26 14:35     ` Christian Lamparter
2014-12-26 19:05       ` Larry Finger [this message]
2014-12-27  0:15         ` Christopher Chavez
2014-12-27 10:10           ` Christian Lamparter
2014-12-27 11:57             ` Christian Lamparter
2014-12-27 18:38               ` Larry Finger
2015-01-01  6:52                 ` Christopher Chavez
2015-01-05  9:33                 ` Johannes Berg
2015-01-05 17:30                   ` Larry Finger
2015-01-06 13:39                     ` [PATCH] mac80211: Re-fix accounting of the tailroom-needed counter Ido Yariv
2015-01-07 13:39                       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549DB187.3090003@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chrischavez@gmx.us \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).